revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

bug: ads toggles

Open OxrxL opened this issue 3 years ago • 2 comments

Type

Other

Bug description

Some general ads patches don't have a settings toggle, but just a direct setvisibility reference.

Steps to reproduce

...

Relevant log output

...

Screenshots or videos

Screenshot_20220712-222303_Samsung Internet

Solution

Change setvisibility with a reference to a dedicated method inside settings.

Additional context

https://github.com/revanced/revanced-patches/blob/main/src/main/kotlin/app/revanced/patches/youtube/ad/general/bytecode/patch/GeneralBytecodeAdsPatch.kt

OxrxL avatar Aug 04 '22 18:08 OxrxL

Please list all the patches which miss the toggle.

oSumAtrIX avatar Aug 04 '22 18:08 oSumAtrIX

Please list all the patches which miss the toggle.

First comment updated with screenshot

OxrxL avatar Aug 04 '22 18:08 OxrxL