revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

bug: disable hide autoplay button crash

Open uvzen opened this issue 2 years ago • 7 comments

Type

Other

Bug description

When I disable the option to hide the autoplay button and when I run the video and click anywhere on the yt application screen, it crashes. I used the latest patches that were released 30 minutes ago. Revanced-cli, patches and integrations I used the latest versions.

Steps to reproduce

  1. disable hiding autoplay button in revanced settings> layout settings> select the autoplay button to make it blue
  2. turn on some video
  3. click on the video being played to try to pause it or change the quality
  4. youtube app should crash

Relevant log output

none

Screenshots or videos

No response

Solution

Don't use the autoplay button until this is fixed

Additional context

No response

uvzen avatar Jul 31 '22 19:07 uvzen

Can you provide an adb logcat for the crash?

TheJeterLP avatar Jul 31 '22 19:07 TheJeterLP

Can you provide an adb logcat for the crash?

Should I just run the adb logcat command and copy everything?

uvzen avatar Jul 31 '22 19:07 uvzen

Can you provide an adb logcat for the crash?

Should I just run the adb logcat command and copy everything?

Look at the readme of revanced-integrations on GitHub for how to get a proper logcat

TheJeterLP avatar Jul 31 '22 19:07 TheJeterLP

Can you provide an adb logcat for the crash?

Should I just run the adb logcat command and copy everything?

Look at the readme of revanced-integrations on GitHub for how to get a proper logcat

Here are the logs. log.txt

uvzen avatar Jul 31 '22 19:07 uvzen

Can you provide an adb logcat for the crash?

Should I just run the adb logcat command and copy everything?

Look at the readme of revanced-integrations on GitHub for how to get a proper logcat

Here are the logs. log.txt

Okay so most of these issues have been fixed already. Could you rebuild and try again?

TheJeterLP avatar Jul 31 '22 19:07 TheJeterLP

Still the same, here a logs from a moment ago. I just built revanced cli, patches and integrations. log.txt

uvzen avatar Jul 31 '22 20:07 uvzen

revanced-cli-2.8.0-all.jar revanced-patches-2.28.1.jar Still crash logcat_08-01-2022_13-55-33.txt

It should be enabling autoplay button

EatVanced avatar Aug 01 '22 06:08 EatVanced

I can confirm I'm having the same issue Root, microg-support excluded, enable-debugging included YouTube 17.29.34 RV CLI 2.8.1 RV Patches 2.28.2 RV Integrations 0.30.4 log.txt

derivativeoflog7 avatar Aug 02 '22 09:08 derivativeoflog7

this needs to use -e hide-autoplay-button in the command line during patching for workaround.... after explicitly excluding those switch, the toggle in layout is working perfectly....

Crescendo-BLYAT avatar Aug 02 '22 13:08 Crescendo-BLYAT

this needs to use -e hide-autoplay-button in the command line during patching for workaround.... after explicitly excluding those switch, the toggle in layout is working perfectly....

Confirmed this workaround works! Thanks....

AMSAMSAMSAMS avatar Aug 03 '22 01:08 AMSAMSAMSAMS

IIrc if you just delete the cache it should be fixed. A recent change was made to the settings, hence the error. Please confirm if it works and close the issue.

oSumAtrIX avatar Aug 03 '22 01:08 oSumAtrIX

IIrc if you just delete the cache it should be fixed. A recent change was made to the settings, hence the error. Please confirm if it works and close the issue.

Wrong. That error you mean was already fixed. This is a different one.

TheJeterLP avatar Aug 03 '22 04:08 TheJeterLP

IIrc if you just delete the cache it should be fixed. A recent change was made to the settings, hence the error. Please confirm if it works and close the issue.

Nope

derivativeoflog7 avatar Aug 03 '22 07:08 derivativeoflog7

:tada: This issue has been resolved in version 2.40.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Aug 22 '22 00:08 github-actions[bot]

Good to know, thanks for the info.

On Tue, Aug 2, 2022, 20:58 Crescendo @.***> wrote:

this needs to use -e hide-autoplay-button in the command line during patching for workaround....

— Reply to this email directly, view it on GitHub https://github.com/revanced/revanced-patches/issues/263#issuecomment-1202631968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQENYWSWHVREWHRU3UEPIGTVXESQ7ANCNFSM55FM6TLA . You are receiving this because you commented.Message ID: @.***>

PalmDevs avatar Oct 11 '22 08:10 PalmDevs