bug: custom-playback-speed patch not working

[TheJeterLP]

trafficstars

Type

Error at runtime

Bug description

So the custom-playback-speed Patch is currently not functional. The setting itself does get saved (see startup log for what values from settings get loaded)

Steps to reproduce

Open settings, change preferred video speed, doesn't do anything

Relevant log output

No log output

Screenshots or videos

No response

Solution

Fix the custom+playback-speed patch so it uses the set value.

Additional context

No response

[TheJeterLP]

probably @bogadana can fix this easily since he's the author of the regarding patch.

[bogadana]

not my patch (does it even exist?)

[Canny1913]

:questionable:

[bogadana]

no such thing as preferred video speed in this patch

[TheJeterLP]

no such thing as preferred video speed in this patch

I changed the title

[TheJeterLP]

no such thing as preferred video speed in this patch

Isn't this exactly what the patch is supposed to do?

[bogadana]

nope

[bogadana]

this is what its supposed to do

[Canny1913]

no such thing as preferred video speed in this patch

Isn't this exactly what the patch is supposed to do?

yeah this patch unlocks more video speeds instead of setting a preferred one

could be modified to do both

[bogadana]

the intent was to have the speeds customisable in the settings but i honestly cant care anymore

[oSumAtrIX]

@bogadana Is doing the correct thing. This way a settings page is not required. It is better to simply save it there automatically instead of having to go to the settings to change it.

[Canny1913]

@bogadana Is doing the correct thing. This way a settings page is not required. It is better to simply save it there automatically instead of having to go to the settings to change it.

if yt speed works similarly to video quality its pretty ez to do

[TheJeterLP]

@bogadana Is doing the correct thing. This way a settings page is not required. It is better to simply save it there automatically instead of having to go to the settings to change it.

The patch doesn't save the last set value tho

[bogadana]

not what its intended for

[oSumAtrIX]

Does it have feature parity with Vanced is the question. If Vanced saved it in the settings this functionality should be added to the menu too. @Canny1913 saves the last selected quality too, for consistency, this can be added too and as @Canny1913 said, it should not be too difficult.

[TheJeterLP]

Does it have feature parity with Vanced is the question. If Vanced saved it in the settings this functionality should be added to the menu too. @Canny1913 saves the last selected quality too, for consistency, this can be added too and as @Canny1913 said, it should not be too difficult.

I agree. Vanced had this feature and this should get implemented into this patch too. The setting in the revanced_prefs.xml can be removed then. Same goes to the code for that in the SettingsFragment. I can do that tomorrow if you want.

[oSumAtrIX]

I am planning on reworking the settings patch into a framework but I do not know what you all are planning to add or remove, hence I will wait for now for you to finish the remaining issues. Please @ me whenever I can start refactoring the patch into said framework.

[TheJeterLP]

I am planning on reworking the settings patch into a framework but I do not know what you all are planning to add or remove, hence I will wait for now for you to finish the remaining issues. Please @ me whenever I can start refactoring the patch into said framework.

No, then I won't add or remove anything. Just start with your framework

[oSumAtrIX]

Alright, I will branch off the latest commit then.

[abuturabofficial]

Any work on that, its pretty frustrating to adjust speed everytime, prefered video speed currently does nothing to make it consistent.

[Canny1913]

Any work on that, its pretty frustrating to adjust speed everytime, prefered video speed currently does nothing to make it consistent.

I'm working on it currently.

[abuturabofficial]

Any work on that, its pretty frustrating to adjust speed everytime, prefered video speed currently does nothing to make it consistent.

I'm working on it currently.

Great, more power to you.

[crazdrama]

Any work on that, its pretty frustrating to adjust speed everytime, prefered video speed currently does nothing to make it consistent.

I'm working on it currently.

would it be possible to add more speed steps btw 2x and 4x...like 2.25x, 2.5x, 2.75x etc??

[oSumAtrIX]

would it be possible to add more speed steps btw 2x and 4x...like 2.25x, 2.5x, 2.75x etc??

Via patch options later on.

[Akv2021]

Any work on that, its pretty frustrating to adjust speed everytime, prefered video speed currently does nothing to make it consistent.

I'm working on it currently.

This is definitely a useful tweak. Is it still in progress ?

[Canny1913]

Any work on that, its pretty frustrating to adjust speed everytime, prefered video speed currently does nothing to make it consistent.

I'm working on it currently.

This is definitely a useful tweak. Is it still in progress ?

Patch has some issues currently but yes.

[Akv2021]

This is definitely a useful tweak. Is it still in progress ?

Patch has some issues currently but yes.

Waiting eagerly for the fix :) Would you like to share any updates ?

[TheJeterLP]

Closed as regarding setting is not existing anymore.