revanced-patches-template
revanced-patches-template copied to clipboard
ReVanced
refactor(YouTube): separate `preferencescreen` for `video quality and speed settings`
On another note, do you consider these patches miscellaneous or interaction?
On another note, do you consider these patches miscellaneous or interaction?
We are not constantly interacting, we just set the quality or speed, and forget about it.
Currently there is only 4 menus under Settings -> ReVanced
Maybe put both video speed and quality under its own top level menu? Settings -> ReVanced -> Video Quality, Speed
@LisoUseInAIKyrios The four menus are currently meant to be pages to hold a list of patch menus/settings. If we add another menu, just for a single patch, then this would break that convention, because now a fifth menu would soley be dedicated for the speed/quality patch. Keep in mind, the Settings patch is used the following way: "SettingsPatch.MISC.add(setting)". If you now add a quality/speed menu, now other patches would for some reason see: "SettingsPatch.QUALITY.add(setting)". Therefore it should be added to an existing menu and not in a dedicated one.
If you introduce this menu, other video related settings should be moved into it.
On a related note, the "Layout" menu is huge and contains the majority of options.
It might be possible to move some of these into the "Interaction" menu: "disable zoom haptics" "hide seekbar" "hide previous & next video buttons" "enable auto-repeat"
(this idea is not included with this PR)
Things like video timestamp don't belong in video playback menu.
Ok, can revert that. What about creator watermark or the other options?
The same applies to them, the menu is labeled as "Settings related to [...] Playback" which is where the conflict happens
if video quality and speed are moved to their own preference, I think it should be a root menu under ReVanced Settings.
Adding a sub menu to Misc makes one more step to reach the video settings, and the Misc menu does not have many entries so it's not overcrowded or any reason to add another level of depth.
If a new root menu is not favorable, then I think the speed and quality settings should remain where they are now (inside Misc) and this PR should be scraped.
The "root" menu is meant as categories. Is "speed" and "quality" a category? Are there patches that can be put inside the category in the future? If these menus are just made to host the current speed and quality settings, it loses it's meaning, which is why it should be inside the misc category instead.