revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

Do not apply playback rate when watching live streams

Open SodaWithoutSparkles opened this issue 2 years ago • 2 comments

Type

Error at runtime

Bug description

Using remember playback rate when watching livestreams will cause the livestream to buffer

Steps to reproduce

  1. Watch any video that is not a livestream
  2. Set the playback rate to something ridiculous (5x)
  3. Exit that video
  4. Watch a livestream such as this
  5. Buffering will happen in less than 2 minutes even if you have good connection
  6. Repeat from step 1 but choose something normal like 2x, observe that the issue still happens but slower
  7. the latency row in stats for nerds will give more information

Relevant log output

Not relevant: this is a logic issue

Screenshots or videos

No response

Solution

When clicking to the livestream, reset to 1x speed, but do not force 1x the entire time, as people may want to catch on from behind with higher playback rate

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.

SodaWithoutSparkles avatar Mar 14 '23 07:03 SodaWithoutSparkles