revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

problem: deprecation of ad views

Open OxrxL opened this issue 3 years ago • 1 comments

🐞 Issue

From the moment that Google moved (and still moving) so many stuff to litho, seems that old ads patches with id "ad_attribution" are not useful anymore.

⚙ Reproduce

Excluding them from patcher shouldn't change anything.

🛠 Solution

Deprecate patches.

OxrxL avatar Jul 12 '22 18:07 OxrxL

https://github.com/revanced/revanced-patches/blob/main/src/main/kotlin/app/revanced/patches/youtube/ad/general/bytecode/patch/GeneralBytecodeAdsPatch.kt

 // list of resource names to get the id of
    private val resourceIds = arrayOf(
        "ad_attribution",

OxrxL avatar Jul 12 '22 18:07 OxrxL

@oSumAtrIX maybe this issue can be closed. ad_attribution components could still be visible if the user don't perform a login.

OxrxL avatar Nov 09 '22 00:11 OxrxL

They should be patched in that case.

oSumAtrIX avatar Nov 09 '22 00:11 oSumAtrIX

They should be patched in that case.

Ok...I'll close this issue so.

OxrxL avatar Nov 09 '22 00:11 OxrxL