revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

Published 20 hours ago • verified publisher icon ReVanced

bug: ReVanced crashes upon trying to use swipe controls after opening app

Open indyroy28 opened this issue 3 years ago • 1 comments

Type

Error at runtime

Bug description

When opening a video on revanced and then trying to use swipe controls immediately after launch, it either crashes or the swipe controls don't work. I have patched ReVanced with the swipe controls patch and the crash doesn't happen if its a few minutes after launching the app but swipe controls still don't work.

Steps to reproduce

Done on Samsung Galaxy Tab A7 on Android 12 Step 1. Open ReVanced Step 2. Open a video immediately after launch Step 3. Try to use swipe controls (with patch applied) Step 4. Swipe controls don't work or revanced crashes

Relevant log output

log of crash:
11-25 15:35:51.677 29234 29234 E AndroidRuntime: FATAL EXCEPTION: main
11-25 15:35:51.677 29234 29234 E AndroidRuntime: Process: app.revanced.android.youtube, PID: 29234
11-25 15:35:51.677 29234 29234 E AndroidRuntime: java.lang.NullPointerException: Parameter specified as non-null is null: method android.view.GestureDetector.onTouchEvent, parameter from
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.controller.gesture.core.BaseGestureController.onScroll(BaseGestureController.kt:3)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.GestureDetector.onTouchEvent(GestureDetector.java:784)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.controller.gesture.core.BaseGestureController.submitTouchEvent(BaseGestureController.kt:41)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.SwipeControlsHostActivity.dispatchTouchEvent(SwipeControlsHostActivity.kt:10)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at ia.dispatchTouchEvent(PG:1)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:974)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.View.dispatchPointerEvent(View.java:15335)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:7807)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7580)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6914)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6971)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6937)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:7135)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6945)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:7192)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6918)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6971)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6937)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6945)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6918)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:10390)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:10238)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:10194)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:10522)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:259)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(Native Method)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java:239)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java:10470)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java:10611)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1108)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.Choreographer.doCallbacks(Choreographer.java:866)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.Choreographer.doFrame(Choreographer.java:789)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1092)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.os.Looper.loopOnce(Looper.java:226)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:313)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:8669)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
11-25 15:35:51.677 29234 29234 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)11-25 15:41:19.712 32128 32128 D AndroidRuntime: Shutting down VM
11-25 15:41:19.717 32128 32128 E AndroidRuntime: FATAL EXCEPTION: main
11-25 15:41:19.717 32128 32128 E AndroidRuntime: Process: app.revanced.android.youtube, PID: 32128
11-25 15:41:19.717 32128 32128 E AndroidRuntime: java.lang.NullPointerException: Parameter specified as non-null is null: method android.view.GestureDetector.onTouchEvent, parameter from
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.controller.gesture.core.BaseGestureController.onScroll(BaseGestureController.kt:3)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.GestureDetector.onTouchEvent(GestureDetector.java:784)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.controller.gesture.core.BaseGestureController.submitTouchEvent(BaseGestureController.kt:41)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.SwipeControlsHostActivity.dispatchTouchEvent(SwipeControlsHostActivity.kt:10)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at ia.dispatchTouchEvent(PG:1)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:974)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.View.dispatchPointerEvent(View.java:15335)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:7807)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7580)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6914)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6971)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6937)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:7135)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6945)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:7192)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6918)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6971)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6937)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6945)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6918)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:10390)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:10238)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:10194)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:10522)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:259)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(Native Method)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java:239)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java:10470)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java:10611)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1108)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.Choreographer.doCallbacks(Choreographer.java:866)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.Choreographer.doFrame(Choreographer.java:789)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1092)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.os.Looper.loopOnce(Looper.java:226)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:313)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:8669)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
11-25 15:41:19.717 32128 32128 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)11-25 15:42:55.595  2997  2997 D AndroidRuntime: Shutting down VM
11-25 15:42:55.596  2997  2997 E AndroidRuntime: FATAL EXCEPTION: main
11-25 15:42:55.596  2997  2997 E AndroidRuntime: Process: app.revanced.android.youtube, PID: 2997
11-25 15:42:55.596  2997  2997 E AndroidRuntime: java.lang.NullPointerException: Parameter specified as non-null is null: method android.view.GestureDetector.onTouchEvent, parameter from
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.controller.gesture.core.BaseGestureController.onScroll(BaseGestureController.kt:3)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.GestureDetector.onTouchEvent(GestureDetector.java:784)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.controller.gesture.core.BaseGestureController.submitTouchEvent(BaseGestureController.kt:41)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at app.revanced.integrations.swipecontrols.SwipeControlsHostActivity.dispatchTouchEvent(SwipeControlsHostActivity.kt:10)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at ia.dispatchTouchEvent(PG:1)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:974)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.View.dispatchPointerEvent(View.java:15335)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:7807)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7580)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6914)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6971)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6937)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:7135)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6945)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:7192)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6918)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6971)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6937)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6945)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6918)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:10390)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:10238)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:10194)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:10522)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:259)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(Native Method)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java:239)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java:10470)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java:10611)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1108)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.Choreographer.doCallbacks(Choreographer.java:866)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.Choreographer.doFrame(Choreographer.java:789)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1092)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.os.Looper.loopOnce(Looper.java:226)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:313)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:8669)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
11-25 15:42:55.596  2997  2997 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

Screenshots or videos

https://user-images.githubusercontent.com/97597724/203971048-ff3fffe0-3344-4429-b571-5362040578c0.mp4

Solution

No response

Additional context

These are the patches that are applied on my ReVanced image App version: 17.45.36 Patched with ReVanced Manager

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.

indyroy28 avatar Nov 25 '22 11:11 indyroy28