revanced-patcher icon indicating copy to clipboard operation
revanced-patcher copied to clipboard

Published 20 hours ago • verified publisher icon ReVanced

bug: `MutableMethod.addInstructions` does not remove dummy nops

Open oSumAtrIX opened this issue 3 years ago • 0 comments

Type

Other

Bug description

When the externalLabels parameter is used, dummy nops are generated to create temporal offsets. These do not get removed when the instructions are added to the method.

Steps to reproduce

Call MutableMethod.addInstructions with the externalLabels parameter. Observe the inserted instructions

Screenshots or videos

Usage:

image

Result:

image

Solution

Remove the dummy nops after they are not used anymore.

oSumAtrIX avatar Aug 21 '22 23:08 oSumAtrIX