revanced-patcher icon indicating copy to clipboard operation
revanced-patcher copied to clipboard

feat: decode resources only when necessary

Open bogadana opened this issue 1 year ago • 9 comments

TODO:

  • First decode resources then run patches

bogadana avatar Jul 28 '22 14:07 bogadana

Implements https://github.com/revanced/revanced-patcher/issues/76

bogadana avatar Jul 28 '22 14:07 bogadana

This will look like the patch takes long to run the patch

no as an appropriate log message is printed

before running the patches, check, a resource patch has been added and decode resources.

tell me how to do this without an instance

bogadana avatar Jul 28 '22 15:07 bogadana

no as an appropriate log message is printed

While running the patches this would be random.

oSumAtrIX avatar Jul 28 '22 16:07 oSumAtrIX

resource patch -> resources need to be decoded dont see how thats random

bogadana avatar Jul 28 '22 16:07 bogadana

While running the patches this would be random.

This is why. The resources should be decoded before the patches are executed. Its separate steps and doing it randomly while the patches execute is random.

oSumAtrIX avatar Jul 28 '22 16:07 oSumAtrIX

Things should always be done as late as possible its not random at all

bogadana avatar Jul 28 '22 16:07 bogadana

While running the patches it doesn't make sense to decode the resources at the same time. Running the patches is one thing, decoding the resources a different. Doing the latter while the patches run is random. Please decode the resources before running the patches by checking if a resource patch has been supplied.

oSumAtrIX avatar Jul 28 '22 16:07 oSumAtrIX

then answer my other question or ditch reflection already

bogadana avatar Jul 28 '22 16:07 bogadana

I have answered your question in the previous message why it is random and reflection will be ditched when annotations are ditched. Please apply the requested changes.

oSumAtrIX avatar Jul 28 '22 16:07 oSumAtrIX