revanced-patcher icon indicating copy to clipboard operation
revanced-patcher copied to clipboard

feat: only do resource patching when required

Open bogadana opened this issue 3 years ago • 6 comments

Type

Functionality

Issue

Currently the user has to manually specify whether resource patching should be enabled.

Feature

Choosing automatically based on whether any resource patches are selected removes the unnecessary manual choice.

Motivation

Disabling resource patching when not required saves a lot of time.

Additional context

No response

bogadana avatar Jul 28 '22 05:07 bogadana

And before you ask this can't easily be done in cli because of dependencies

bogadana avatar Jul 28 '22 05:07 bogadana

Same case with manager ^

Aunali321 avatar Jul 28 '22 05:07 Aunali321

And before you ask this can't easily be done in cli because of dependencies

Why?

oSumAtrIX avatar Jul 28 '22 08:07 oSumAtrIX

And before you ask this can't easily be done in cli because of dependencies

Why?

Are dependencies accessible without an instance?

bogadana avatar Jul 28 '22 12:07 bogadana

Yes, you have access to the classes compile time annotations before having to create an instance of the class.

oSumAtrIX avatar Jul 28 '22 12:07 oSumAtrIX

Still I think it makes more sense in patcher. There's no reason to give it resource patches and then disable resource patching. Would avoid duplicate code between the cli/manager too

bogadana avatar Jul 28 '22 12:07 bogadana