revanced-patcher icon indicating copy to clipboard operation
revanced-patcher copied to clipboard

Published 20 hours ago • verified publisher icon ReVanced

fix: slightly better fuzzy scanning

Open MewtR opened this issue 3 years ago • 9 comments

Closes #89

MewtR avatar Oct 10 '22 02:10 MewtR

Before merging, can you rebase & test this PR against all patches for YouTube?

oSumAtrIX avatar Dec 02 '22 01:12 oSumAtrIX

Can this be merged soonish? PR has been open for a long while now, waiting for @oSumAtrIX to review.

Sculas avatar Dec 14 '22 00:12 Sculas

If possible, please test this against a majority of the existing patches.

oSumAtrIX avatar Dec 14 '22 00:12 oSumAtrIX

Hey, apologies for the delayed reply. I won't be able to look at this for quite some time. If someone else can pick it up that'd be great or else I think it'd be safer to close the PR.

MewtR avatar Dec 21 '22 23:12 MewtR

Well it can stay open just fine until we can test it.

oSumAtrIX avatar Dec 21 '22 23:12 oSumAtrIX

@oSumAtrIX This should be reopened.

Sculas avatar May 05 '23 23:05 Sculas

What's keeping this PR from being merged after almost a year? Is no one available from the team to test this change, if necessary? This PR is quite essential, given that my implementation of fuzzy scanning is pretty mediocre.

Sculas avatar Sep 26 '23 19:09 Sculas

It has low priority because it is currently unnecessary as well as needs to be tested if its breaking

oSumAtrIX avatar Sep 26 '23 19:09 oSumAtrIX

I believe, if we want to properly fix and implement fuzzy scanning, something like https://github.com/intuit/fuzzy-matcher should be used instead.

oSumAtrIX avatar Feb 14 '24 00:02 oSumAtrIX