revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

navigation bar color.

Open danieloox opened this issue 2 years ago • 5 comments

Type

Cosmetic

Branch

flutter

Issue

White navbar on dark mode.

Feature

Make this dark in dark mode :) 20220915_124050

Motivation

better look :)

Additional context

No response

danieloox avatar Sep 15 '22 11:09 danieloox

Fixed with https://github.com/revanced/revanced-manager/commit/9f58757cafa2e36ff0660cb63f983666ecbd3957.

ponces avatar Sep 15 '22 14:09 ponces

I have updated to the newest version, but experiencing the issue still. I guess that Miui is the problem.

Running Miui 12.0.3

Screenshot_2022-09-16-01-33-36-784_app revanced manager flutter

And a link to a similar issue https://github.com/florisboard/florisboard/issues/1694

FabiRich avatar Sep 15 '22 23:09 FabiRich

maybe is a miui problem. In 0.0.7 navbar works fine for me. dark is dark, white is white.

danieloox avatar Sep 16 '22 11:09 danieloox

0.0.7 MIUI 13 (Android 11)

Screenshot_2022-09-16-08-39-25-787_app revanced manager flutter

Seems fine here, even though I'd not normally notice since I think most people use Fullscreen/Gesture navigation? xD I might be able to test MIUI 13 with Android 12 Soonâ„¢.

Spacellary avatar Sep 16 '22 11:09 Spacellary

https://user-images.githubusercontent.com/76914324/190734263-5a742c40-b09d-45e7-b22b-92f342683a58.mov

https://user-images.githubusercontent.com/76914324/190734357-524600c7-6306-41d4-b107-cb55a3784e1e.mov

I tested it and it only appears on the dark mode of Miui, but I can see a sligh difference, when turning in on and off in the ReVanced Manager settings. And yes I usually use gestures too, but wanted to check this issue

FabiRich avatar Sep 16 '22 20:09 FabiRich

Feature is implemented. Not Manager's fault that OS can't handle this. Closed.

ponces avatar Sep 18 '22 00:09 ponces