revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: revanced manager offers wrong update version

Open masterflitzer opened this issue 2 years ago • 6 comments

Type

Error while running the manager

Bug description

revanced manager internal update functionality offers pre-releases from github instead of stable releases

pre-releases shouldn't be offered (or only from pre-release versions)

Steps to reproduce

  1. download the currently latest stable release (https://github.com/revanced/revanced-manager/releases/download/v0.1.0/revanced-manager-0.1.0.apk)
  2. install and open app
  3. on the dashboard revanced manager offers a dev version (pre-release on github)

Android version

Android 13 - OneUI 5.1

Manager version

github: v0.1.0 in app: v1.0.0

i opened a seperate issue about versions not matching: #842

Target package name

N/A

Target package version.

N/A

Installation type

Non-root

Patches selected.

N/A

Device logs (exported using Manager settings).

N/A

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

screenshot

Solution

No response

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager and not related to patching errors or patches

masterflitzer avatar May 02 '23 14:05 masterflitzer

The 1.0 release was removed?

Rafee-M avatar May 02 '23 21:05 Rafee-M

The 1.0 release was removed?

Yes, it's not in the releases section already

AnonymouseHucker29 avatar May 02 '23 21:05 AnonymouseHucker29

But why has it been removed? I installed it upon release and it's working fine.

jaepil-choi avatar May 03 '23 23:05 jaepil-choi

Because it was not working fine, please do not spam issues.

oSumAtrIX avatar May 04 '23 00:05 oSumAtrIX

the fundamental issue of offering pre-releases as updates to full releases is still there no? is this unwanted behavior or not? I mean if not everything can be a release and pre-releases don't matter at all

masterflitzer avatar May 04 '23 04:05 masterflitzer

The capability of returning pre-releases in the API is not yet achieved, it's likely that it was a mistake elsewhere such as the name of the release or the release type not being what it should've been

Ushie avatar May 04 '23 08:05 Ushie