revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: No patched applications installed shown

Open DarkSkull91 opened this issue 2 years ago • 9 comments

Type

Error while running the manager

Bug description

In the Dashboard section, under the installed patched applications there are nothing even if I have patched both Youtube and Twitter.

Steps to reproduce

  1. Open the vanced manager
  2. See that in the installed section under patched application you have the message: "No patched applications installed"

Android version

Android 12.1

Manager version

0.0.44

Target package name

com.google.android.youtube com.twitter.android

Target package version.

Youtube 17.45.36 Twitter 9.65.6-release.0

Installation type

Root

Patches selected.

All

Device logs (exported using Manager settings).

N/A

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • [x] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

DarkSkull91 avatar Dec 06 '22 08:12 DarkSkull91

  1. Its revanced manager
  2. This is a known issue.
  3. Edit: A known issue does not mean its fixed

SodaWithoutSparkles avatar Dec 06 '22 14:12 SodaWithoutSparkles

Still an issue on 0.0.44

BabyOilJohnson avatar Dec 06 '22 14:12 BabyOilJohnson

This is caused by the update functionality being disabled. @Aunali321 You might want to enable it back, or just remove it completely for now.

PalmDevs avatar Dec 07 '22 04:12 PalmDevs

@PalmDevs can this be re-enabled without first fixing the spilt-apk patch issue?

SodaWithoutSparkles avatar Dec 07 '22 05:12 SodaWithoutSparkles

@PalmDevs can this be re-enabled without first fixing the spilt-apk patch issue?

Of course

PalmDevs avatar Dec 07 '22 06:12 PalmDevs

If you re-patch the apk for the app you have installed, but then do not install it, the manager will list it under patched applications again (at least for a couple days...)

adanvdo avatar Dec 19 '22 00:12 adanvdo

ReVanced Manager:

Clear cache Clear data

Open app

All good ?

kenethc avatar Jan 10 '23 02:01 kenethc

ReVanced Manager:

Clear cache Clear data

Open app

All good ?

  1. Dont try this before you backup your keystore, or you wont be able to update and have to delete revanced and re-install
  2. Clear data also clears cache

SodaWithoutSparkles avatar Jan 10 '23 05:01 SodaWithoutSparkles

Never had an issue tbh Not once !

On Tue, Jan 10, 2023, 11:14 SodaWithoutSparkles @.***> wrote:

ReVanced Manager:

Clear cache Clear data

Open app

All good ?

  1. Dont try this before you backup your keystore, or you wont be able to update and have to delete revanced and re-install
  2. Clear data also clears cache

— Reply to this email directly, view it on GitHub https://github.com/revanced/revanced-manager/issues/565#issuecomment-1376763555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYVPBVIKAWH4UTJY2OGJ23WRTZMTANCNFSM6AAAAAASVHTEQQ . You are receiving this because you commented.Message ID: @.***>

kenethc avatar Jan 10 '23 05:01 kenethc

Isn't this related to #674 ?

Iirc it only shows for mounted apps.

oSumAtrIX avatar Feb 11 '23 17:02 oSumAtrIX

Isn't the OP talking about the patched applications only right?

Yes, but for regularly patched and installed apps iirc it doesn't show.

oSumAtrIX avatar Feb 11 '23 17:02 oSumAtrIX

What do you mean by mounted and regular apps?

This has a high chance of being fixed. The logic seems to be correct. Maybe wait for a few days and close this. If so adding a label like "fix: verifying" would be nice.

Side note: Please also add labels like "fix: WIP", "fix: in next release", "bug: confirmed", "bug: needs confirmation", "stale issue" for easier tracking.

SodaWithoutSparkles avatar Feb 11 '23 18:02 SodaWithoutSparkles

Yes, but for regularly patched and installed apps iirc it doesn't show.

Regularly patched does show now.

Confirm that by mounted you mean installed as root? If so regularly patched app now shows. I dont know whats before as I dont have root, but apps are not shown.

Edit: Clarify

SodaWithoutSparkles avatar Feb 11 '23 18:02 SodaWithoutSparkles

Yes, but for regularly patched and installed apps iirc it doesn't show.

Regularly patched does show.

Confirm that by mounted you mean installed as root? If so regularly patched app now shows. I dont know whats before as I dont have root, but apps are not shown.

Okay, I see the OP had the rooted version. Same as I'm not a rooted user, I can't confirm this issue exists or not. So let it be open then.

Okay, I see the OP had the rooted version.

How did you get the conclusion? I didnt see that mentioned.

SodaWithoutSparkles avatar Feb 11 '23 18:02 SodaWithoutSparkles

Installation type

Root

Installation type

Root

Ah sorry!

SodaWithoutSparkles avatar Feb 12 '23 02:02 SodaWithoutSparkles

So this is a known issue and can't be closed I guess.

https://github.com/revanced/revanced-manager/commit/5d63d5c2d3b4f22e9f65384e06a0a31660988816 this is supposed to fix the issue. But it's not tested enough. Code wise everything should work fine now.

Aunali321 avatar Feb 12 '23 09:02 Aunali321

5d63d5c this is supposed to fix the issue. But it's not tested enough. Code wise everything should work fine now.

This was pushed during 0.0.55. I believe the "potentially" in the title suggests it requires some more refining as I have raised an issue myself #692 reporting several issues that came with it.

I have raised an issue myself #692 reporting several issues that came with it.

Those are different issues. The only issue it is supposed to solve is avoid patched apps disappearing when an "patch update" is available for the patched app. It showing outdated info is different issue.

Aunali321 avatar Feb 12 '23 09:02 Aunali321

But as I mentioned in the issues, I am still having no apps installed in my pixel device though.

Screenshot_20230212-152849~2 How it is for me right now.

I second this. Uses to happen to me all the time.

I just cleared data for the Manager and then that would fix the issue.

On Sun, Feb 12, 2023, 15:30 ILoveOpenSourceAppications < @.***> wrote:

[image: Screenshot_20230212-152849~2] https://user-images.githubusercontent.com/117499019/218304463-d594bc8e-13b1-45e3-bba6-a8628568478d.png How it is for me right now.

— Reply to this email directly, view it on GitHub https://github.com/revanced/revanced-manager/issues/565#issuecomment-1426990051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYVPBWAR6HN72OUAO4NLATWXCYC5ANCNFSM6AAAAAASVHTEQQ . You are receiving this because you commented.Message ID: @.***>

kenethc avatar Feb 13 '23 15:02 kenethc

I second this. Uses to happen to me all the time. I just cleared data for the Manager and then that would fix the issue.

You my friend are talking about an issue which was present with an older version of the manager. This fix worked with those older versions, but not anymore.

Ok thanks for the info.

On Mon, Feb 13, 2023, 21:57 ILoveOpenSourceApplications < @.***> wrote:

I second this. Uses to happen to me all the time. I just cleared data for the Manager and then that would fix the issue. You my friend are talking about an issue which was present with older version of manager. This fix worked with those older versions, but not anymore.

— Reply to this email directly, view it on GitHub https://github.com/revanced/revanced-manager/issues/565#issuecomment-1428243482, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYVPBUMBZXA4WA7ZXCKPIDWXJOHDANCNFSM6AAAAAASVHTEQQ . You are receiving this because you commented.Message ID: @.***>

kenethc avatar Feb 14 '23 06:02 kenethc

Confirmed that works deleting the data.

DarkSkull91 avatar Feb 14 '23 08:02 DarkSkull91