revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: Wrong renaming of exported apk if there is already an apk with the same name.

Open d3EyedRaven opened this issue 2 years ago • 1 comments

Type

Other

Bug description

saving apk in same folder and with same name, saves apk with changed extension instead of , rendering apk useless. on personal level, issue can be fixed by simple renaming.

example: should save second export as youtube-revanced_v17.45.36 1.apk currently saves second export as : youtube-revanced_v17.45.36.apk 1

Steps to reproduce

1: export the apk after patching. save it in file manager (in my case mixplorer) with default naming "youtube-revanced_v17.45.36.apk"

2: patch youtube again with different patches, export again in the same folder as previously exported apk. and same name. it does not ask to change name or whether to replace old file.

3: instead it renames to "youtube-revanced_v17.45.36.apk 1" which renders apk useless due to the wrong extention. however a simple rename solve sthe issue. it should be asking if to replace the old file or rename the filename, not with the extention.

Relevant log output

none

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.

d3EyedRaven avatar Dec 03 '22 20:12 d3EyedRaven

This still exists and needs to be looked into.