revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: Changing language breaks the app UI

Open arseniiarsenii opened this issue 2 years ago • 7 comments

Type

Error at runtime

Bug description

  1. Language list doesn't appear the first time it is opened
  2. Changing the language breaks the apps UI. Element's display their translation keys instead of the actual translation value.

See screencast attached.

Steps to reproduce

  1. Open manager
  2. Go.to settings
  3. Switch the language to another one (I tried Russian)
  4. Restart the app

Android version

Android 12 (Oxygen OS)

Manager version

0.0.41

Target package name

None

Target package version.

None

Installation type

Non-root

Patches selected.

None

Device logs (exported using Manager settings).

None

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

https://user-images.githubusercontent.com/74658894/203654692-069fb95f-894f-4454-9068-b7817fc282c7.mp4

Solution

No response

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

arseniiarsenii avatar Nov 23 '22 22:11 arseniiarsenii

  1. I can reproduce the first issue.
  2. It seems currently only the english and hindi jsons are (manually) added to revanced (https://github.com/revanced/revanced-manager/tree/flutter/assets/i18n). For hindi the translation works. So I think:
    • The GitHub integration of Crowdin should be added
    • If a language doesn't exist/has no translated strings, don't show it as possible language
    • If a string is not translated, use the english string, don't show the string-name
  3. Another UI bug: If I set hindi as language, "English" is still displayed as "Language" (see image) grafik

CennoxX avatar Nov 24 '22 08:11 CennoxX

Italian is the same issue

speedlorenzo12 avatar Nov 24 '22 08:11 speedlorenzo12

Italian is the same issue

As said, the issue is the same for every language, except English and Hindi.

CennoxX avatar Nov 24 '22 09:11 CennoxX

In version 0.0.42 now all language assets are added, but the the language list still doesn't appears, and is not opened, even on a second try (this was working in 0.0.41).

CennoxX avatar Nov 26 '22 23:11 CennoxX

Language selection will be removed in the meantime until a fulfilling implementation has been done

Ushie avatar Nov 28 '22 17:11 Ushie

This issue is potentially fixed in #1450

validcube avatar Nov 11 '23 08:11 validcube

On v1.19.0-dev.17 which is supposed to fix language specific issues, selecting Greek still results in this:

Screenshot_2024-03-02-15-58-28-524_app revanced manager flutter

n1cKz1 avatar Mar 02 '24 14:03 n1cKz1

On v1.19.0-dev.17 which is supposed to fix language specific issues, selecting Greek still results in this:

was this issue resolved or should I create a new issue? I can't test latest dev release for myself since that version crashes on startup for some reason

n1cKz1 avatar Mar 05 '24 00:03 n1cKz1