revanced-manager
revanced-manager copied to clipboard
bug: Changing language breaks the app UI
Type
Error at runtime
Bug description
- Language list doesn't appear the first time it is opened
- Changing the language breaks the apps UI. Element's display their translation keys instead of the actual translation value.
See screencast attached.
Steps to reproduce
- Open manager
- Go.to settings
- Switch the language to another one (I tried Russian)
- Restart the app
Android version
Android 12 (Oxygen OS)
Manager version
0.0.41
Target package name
None
Target package version.
None
Installation type
Non-root
Patches selected.
None
Device logs (exported using Manager settings).
None
Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].
No response
Screenshots or videos
https://user-images.githubusercontent.com/74658894/203654692-069fb95f-894f-4454-9068-b7817fc282c7.mp4
Solution
No response
Additional context
No response
Acknowledgements
- [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
- [X] I have written a short but informative title.
- [X] I filled out all of the requested information in this issue properly.
- [X] The issue is related solely to the ReVanced Manager
- I can reproduce the first issue.
- It seems currently only the english and hindi jsons are (manually) added to revanced (https://github.com/revanced/revanced-manager/tree/flutter/assets/i18n). For hindi the translation works. So I think:
- The GitHub integration of Crowdin should be added
- If a language doesn't exist/has no translated strings, don't show it as possible language
- If a string is not translated, use the english string, don't show the string-name
- Another UI bug: If I set hindi as language, "English" is still displayed as "Language" (see image)
Italian is the same issue
Italian is the same issue
As said, the issue is the same for every language, except English and Hindi.
In version 0.0.42 now all language assets are added, but the the language list still doesn't appears, and is not opened, even on a second try (this was working in 0.0.41).
Language selection will be removed in the meantime until a fulfilling implementation has been done
This issue is potentially fixed in #1450
On v1.19.0-dev.17 which is supposed to fix language specific issues, selecting Greek still results in this:
On v1.19.0-dev.17 which is supposed to fix language specific issues, selecting Greek still results in this:
was this issue resolved or should I create a new issue? I can't test latest dev release for myself since that version crashes on startup for some reason