revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: mount script is not the same on revanced-cli and revanced-manager

Open diogotcorreia opened this issue 2 years ago • 1 comments

Type

Other

Bug description

image

I was getting crazy trying to uninstall the app that I installed through Revanced Manager with the CLI and vice versa. Turns out they aren't compatible, that is, the CLI writes to a certain path (/data/adb/service.d/mount_revanced_<package>.sh) while the app writes to another (/data/adb/service.d/<package.sh>), as you can see in the screenshot above.

I'm not sure if this is intended or not, so I'm reporting this. I always thought the CLI and the manager were interchangeable.

Relevant code (CLI): https://github.com/revanced/revanced-cli/blob/f68e7697ff18586b266926b831ba9f2827d3db39/src/main/kotlin/app/revanced/utils/adb/Adb.kt#L79 https://github.com/revanced/revanced-cli/blob/f68e7697ff18586b266926b831ba9f2827d3db39/src/main/kotlin/app/revanced/utils/adb/Constants.kt#L27

Relevant code (Manager): https://github.com/revanced/revanced-manager/blob/c5958f1257e779943b7389bec0125fe2d6ce8bc5/lib/services/root_api.dart#L99

Steps to reproduce

  1. Patch the YouTube app using Revanced Manager on Android using the root install method.
  2. Try to uninstall it with the CLI (using the --uninstall flag).
  3. (optional) Reinstall the YouTube app
  4. The app is still patched (after reboot at least)

Relevant log output

None

Screenshots or videos

No response

Solution

No response

Additional context

I had previously installed YouTube Revanced through the CLI but at a later time I changed to the Manager. This has had conflicts on restarts for a while now, but I couldn't understand why until I noticed I was getting mounts without patching the app.

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.

diogotcorreia avatar Nov 15 '22 20:11 diogotcorreia

The CLI mounts where Vanced originally mounted their patched APK files. This should be addressed in the ReVanced Manager.

oSumAtrIX avatar Nov 15 '22 20:11 oSumAtrIX