revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

feat: Option to keep system font

Open xerta555 opened this issue 2 years ago • 4 comments

Type

Functionality

Issue

ReVanced app use custom font

Feature

Please add an option to keep system font

Motivation

If the users want, they would enable the option and the app would keep the system font. In this way, if a user use a custom font which break the app display, he will just have to delete app's data to get it works again.

With this option, all users will be happy.

Additional context

Users who install custom fonts are aware of this, so if their custom font has a problem, they will know what to do about it.

The fact that a font is forced by the application itself is very annoying, at least leaving the choice to the users seems to be the best idea.

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

xerta555 avatar Nov 12 '22 00:11 xerta555

Is this feature request actually attainable?

Should be. But it's quite irrelevant.

oSumAtrIX avatar Feb 12 '23 17:02 oSumAtrIX

I guess since it's a feature request it depends on y'all developers to decide to keep it open or not.

I thought adding an option to keep the system default font instead of an imposed font was so complicated. I have the impression that the problem is more at the decision level than at the technical level.

xerta555 avatar Feb 12 '23 17:02 xerta555

ReVanced Manager will soon be released as a full rewrite. Over time, many feature requests have been made for the current version of ReVanced Manager, but to accelerate the development of the new version of ReVanced Manager, we have to focus on it, which I am closing this issue according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long/ Low priority/ Maintainers un-interested/ Too complex to realize
  • Feature planned/ already implemented for the new version of ReVanced Manager

Regardless, anyone who comes across this feature request can PR it to the current version of ReVanced Manager until the new version is ready. Thanks for your feature request!

oSumAtrIX avatar Jun 17 '24 20:06 oSumAtrIX