revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: S Pen interactions crashes manager

Open Voiasis opened this issue 3 years ago • 9 comments

Type

Error while running the manager

Bug description

I tried to copy the recommended YouTube version by holding the S Pen button and tapping the screen twice. (It supposed to bring up a s pen tool menu) The manager crashes immediately on the first tap. It crashes anywhere within the manager.

Steps to reproduce

  1. Hold S Pen button
  2. Touch screen anywhere in manager

Android version

12

Manager version

0.0.32

Target package name

None

Target package version.

None

Installation type

Non-root

Patches selected.

None

Device logs (exported using Manager settings).

--------- beginning of main
10-11 19:22:44.305  1054  1054 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:23:04.381  1940  1940 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:23:59.583  3587  3587 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:31:24.900  9039  9039 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:32:34.763  9876  9876 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:32:39.162 10022 10022 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:34:48.377 13768 13768 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:35:34.853 13768 13768 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.unregisterNetworkCallback(ConnectivityManager.java:4839)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onCancel(ConnectivityBroadcastReceiver.java:66)] [dev.fluttercommunity.plus.connectivity.ConnectivityPlugin.teardownChannels(ConnectivityPlugin.java:51)] [dev.fluttercommunity.plus.connectivity.ConnectivityPlugin.onDetachedFromEngine(ConnectivityPlugin.java:29)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.remove(FlutterEngineConnectionRegistry.java:270)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.remove(FlutterEngineConnectionRegistry.java:280)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.removeAll(FlutterEngineConnectionRegistry.java:288)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.destroy(FlutterEngineConnectionRegistry.java:121)] [io.flutter.embedding.engine.FlutterEngine.destroy(FlutterEngine.java:427)] [io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onDetach(FlutterActivityAndFragmentDelegate.java:704)] [io.flutter.embedding.android.FlutterActivity.onDestroy(FlutterActivity.java:715)] [android.app.Activity.performDestroy(Activity.java:8571)] [android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1364)] [android.app.ActivityThread.performDestroyActivity(ActivityThread.java:6019)] [android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:6077)] [android.app.servertransaction.DestroyActivityItem.execute(DestroyActivityItem.java:47)] [android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)] [android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)] [android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)] [android.app.ActivityThread$H.handleMessage(ActivityThread.java:2443)]
10-11 19:35:36.540 13768 13768 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:35:41.187 14577 14577 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

Voiasis avatar Oct 12 '22 02:10 Voiasis

Don't have S pen to test. and you can't "copy" over apk. you need to tap the button and select it from your file manager.

Aunali321 avatar Oct 12 '22 08:10 Aunali321

I can copy any text on the screen with my s pen. It's called "Smart Select". I just double tap the screen, select the area of text I want to copy, select extract text, then copy. That's what I wanted to do and it crashes.

Voiasis avatar Oct 12 '22 16:10 Voiasis

Same issue here, touching screen while the button is pressed, crashes Vanced Manager.

Michael1999US avatar Oct 12 '22 17:10 Michael1999US

I can copy any text on the screen with my s pen. It's called "Smart Select". I just double tap the screen, select the area of text I want to copy, select extract text, then copy. That's what I wanted to do and it crashes.

It won't work, because manager isn't copying apk. When you select apk it only it gets it's path. Copying is done afterwards. So no you can't drag and drop apk like that

Aunali321 avatar Oct 18 '22 06:10 Aunali321

I can copy any text on the screen with my s pen. It's called "Smart Select". I just double tap the screen, select the area of text I want to copy, select extract text, then copy. That's what I wanted to do and it crashes.

It won't work, because manager isn't copying apk. When you select apk it only it gets it's path. Copying is done afterwards. So no you can't drag and drop apk like that

That's not what they're referring to, they're trying to copy the recommended version text, using a feature called SmartSelect, not the APK

Screenshot_20221018_140730

Ushie avatar Oct 18 '22 11:10 Ushie

However I can't test either, as I don't have an S-Pen as well

Ushie avatar Oct 18 '22 11:10 Ushie

Why can't I be a tester then. I'm a tester for another Android project. Just ping me in the Discord server

Voiasis avatar Oct 21 '22 02:10 Voiasis

I have a spen. I can test.

arandomhooman avatar Nov 03 '22 22:11 arandomhooman

I have a spen. I can test.

~~I don't believe there's a need, I realised recently that this is most likely the same issue as #250~~

scrape that, that seems to be specific to textfield

Ushie avatar Nov 03 '22 22:11 Ushie

Do we have anymore S-Pen users to test this and see if the issue still exists?

This issue seemed to relate to Flutter issue https://github.com/flutter/flutter/issues/111068 The issue has been fixed in Flutter framework in November 2022, I've done own testing on one of recent versions of ReVanced Manager and can confirm this issue is not present anymore.

ghost avatar Feb 26 '23 20:02 ghost