revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: YouTube ReVanced crashes upon playing video

Open ghost opened this issue 3 years ago • 16 comments

Type

Error at runtime

Bug description

Once YouTube is patched by Revanced Manager (root mode), upon playing any video the app crashes.

Steps to reproduce

  • Install YouTube app v17.36.37
  • Install ReVanced Manager v0.0.28
  • In ReVanced Manager, after granting all required permissions, go to Patcher and select the installed YouTube app
  • Select all chosen patches (in this example, to keep it simple, I selected only General Ads 0.0.1 and Video Ads 0.0.1)
  • Start patching, then once successfully patched choose Install as Root
  • Open patched YouTube app and play a video

Android version

Android Version: 13 Phone: Rooted Pixel 6 XL Kernel version: 5.10.107-android13-4-00008-g466e95df8c7c-ab8760753 #1 Thu Jun 23 15:42:45 UTC 2022 Build number: TP1A.220905.004

Manager version

0.0.28

Target package name

YouTube

Target package version.

17.36.37 - arm64 - v8a - nodpi

Installation type

Root

Patches selected.

General Ads 0.0.1 Video Ads 0.0.1

Device logs (exported using Manager settings).

--------- beginning of system
10-03 14:17:14.947 29456 29456 W PackageParser: Unknown element under <manifest>: queries at /data/user/0/app.revanced.manager.flutter/cache/file_picker/com.google.android.youtube_17.36.37-1531571648_minAPI26(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk Binary XML file line #41
10-03 14:17:49.455 29456 29456 W PackageParser: Unknown element under <manifest>: queries at /data/user/0/app.revanced.manager.flutter/cache/file_picker/com.google.android.youtube_17.36.37-1531571648_minAPI26(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk Binary XML file line #41
--------- beginning of main
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=14
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=14
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=15
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=14
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=15
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=16

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

Tried clearing YouTube app's cache and data, did not resolve. Tried using different patches, did not resolve.

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

ghost avatar Oct 03 '22 03:10 ghost

I can confirm this bug. I'm using the same patcher and youtube version.

jclohmann avatar Oct 03 '22 08:10 jclohmann

got the same exact issue solved by simply reboot my device

LorisTecnology avatar Oct 03 '22 11:10 LorisTecnology

Rebooting did not help in my case.

ghost avatar Oct 03 '22 12:10 ghost

uninstall updates for youtube, Install full apk from apkmirror(17.36.37,120mb+), and select yt from application selector and patch it. make sure to exclude microg patch.

Aunali321 avatar Oct 05 '22 08:10 Aunali321

That's exactly how I installed it. But still got the issue. P.S. For the time being I'm using the magisk module which doesn't cause any crashes.

ghost avatar Oct 05 '22 23:10 ghost

This must be in patches repo not here. Here is only app bugs.

ViktorVoloshko avatar Oct 28 '22 23:10 ViktorVoloshko

This started happening today for me (also crashes trying to preload videos without pressing on them), just updated the manager re-patched my YouTube with the same patches I always use. Recommend YouTube version, this now happens with older manager version too, I also tried removing the root/data/adb/services.d/YouTube file no luck. YouTube music has no problems.

thijsi123 avatar Jan 02 '23 20:01 thijsi123

Please grep for "AndroidRuntime" while using logcat and catch the exception

oSumAtrIX avatar Jan 02 '23 20:01 oSumAtrIX

I have no idea what that means, but I'll try my best!

thijsi123 avatar Jan 02 '23 21:01 thijsi123

FATAL EXCEPTION: main Process: com.google.android.youtube, PID: 12606 aslz: The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with. Further reading: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling | java.lang.NoClassDefFoundError: Failed resolution of: Lapp/revanced/integrations/patches/downloads/DownloadsPatch; at aqvq.w(PG:8) at aslj.run(PG:2) at android.os.Handler.handleCallback(Unknown Source:2) at android.os.Handler.dispatchMessage(Unknown Source:4) at android.os.Looper.loopOnce(Unknown Source:176) at android.os.Looper.loop(Unknown Source:77) at android.app.ActivityThread.main(Unknown Source:155) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Unknown Source:11) at com.android.internal.os.ZygoteInit.main(Unknown Source:306) Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Lapp/revanced/integrations/patches/downloads/DownloadsPatch; at com.google.android.apps.youtube.app.common.player.PlaybackLifecycleMonitor.l(PG:4) at fmq.a(PG:46) at atkn.tt(PG:2) at asuu.tt(PG:1) at asur.d(PG:10) at asur.tt(PG:2) at astw.g(PG:1) at astu.run(PG:1) at aewa.run(PG:3) at aslj.run(PG:1) ... 8 more Caused by: java.lang.ClassNotFoundException: app.revanced.integrations.patches.downloads.DownloadsPatch ... 18 more

thijsi123 avatar Jan 02 '23 22:01 thijsi123

Are you merging the integrations correctly?

oSumAtrIX avatar Jan 02 '23 22:01 oSumAtrIX

Uhmm, Still no idea what that means, I just select the patches - patch- install as root and then open.

thijsi123 avatar Jan 02 '23 22:01 thijsi123

I am unable to reproduce, I'll leave this issue open for someone else to reproduce the same exception.

oSumAtrIX avatar Jan 02 '23 22:01 oSumAtrIX

Seems like that it was the downloader patch, everything works now.

thijsi123 avatar Jan 02 '23 22:01 thijsi123

You are using unofficial patches it seems. Reset the sources and it will work again.

oSumAtrIX avatar Jan 02 '23 22:01 oSumAtrIX

Ahh yes, I totally forgot. Thank you very much!

thijsi123 avatar Jan 02 '23 22:01 thijsi123

If everything is solved can this be closed then?