revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: make manager responsive

Open xafn opened this issue 3 years ago • 4 comments

Type

Cosmetic

Bug description

With how it is currently, the text in cards is hardcoded to shorten after a set amount of characters. This should be changed to shorten based on the available width.

Also, if there is no space for buttons on the same line, replace them with an icon or put in on a newline.

This is how the dashboard looks right now with largest font and largest display size. Everything gets clipped. image

Steps to reproduce

  1. Increase font size/display size
  2. Look at Dashboard or Patch selection

Android version

any

Manager version

0.0.26

Target package name

why is this required

Target package version.

why is this required

Installation type

Non-root

Patches selected.

why is this required

Device logs (exported using Manager settings).

guhhh

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

xafn avatar Sep 30 '22 06:09 xafn

Your fault for using manager designed for a modern smartphone on a 2 inch device.

Aunali321 avatar Sep 30 '22 06:09 Aunali321

The reason I opened this issue was because of this reddit post. It's for accessibility.

xafn avatar Sep 30 '22 06:09 xafn

Also, this issue still occurs to people with regular phones. One person in the Discord had the Info buttons going off the card with a OnePlus 6T.

xafn avatar Sep 30 '22 06:09 xafn

I'll look into it real quick. This can probably be handled with flutter_screenutil.

schrobingus avatar Oct 05 '22 23:10 schrobingus

Does #1017 fix this @TheAabedKhan?

no, it only improves certain text, something like #361 would be necessary to resolve UI components going out of frame etc

Ushie avatar Jul 14 '23 08:07 Ushie

Okay. Got it!