ReVanced
fix: Adjust ReVanced icons
Fix incorrect icon logo, https://github.com/ReVanced/revanced-manager/issues/1124 and Splash screen is a broken in light mode from https://github.com/ReVanced/revanced-manager/issues/1191#issue-1873984131
Round/Adaptive icon
| Before (xxhdpi) | After (xxhdpi) |
|---|---|
Monochrome icon
Splash screen
| Dark | Light |
|---|---|
@oSumAtrIX Look at these 2 icons and finally decide which one to use? rounded or sharp?
https://github.com/ReVanced/revanced-branding/blob/main/assets/revanced-logo/revanced-logo.svg
https://github.com/ReVanced/revanced-branding/blob/main/assets/revanced-logo/revanced-logo-shape.svg
@Ushie both files are in the branding repo.
Somehow two slightly different designs exist there, and nobody has noticed until now.
We should make a decision, then delete/fix the incorrect icons in that repo.
It seems this file is the only file with the conflicting design (sharp edges and not rounded).
Since all the other branding image resources use rounded edges, I think was can say this the rounded design used by the 7 other files is the correct design.
So the solution is to use the rounded design here, and open a new issue in the branding repo so that incorrect file can be fixed/deleted?
The second logo (the sharp one) has been used as the icon in the manager for 2 years, although with incorrect proportions of the foreground area of the adaptive icon.
Because of this, we updated the icons in the custom branding patch for YouTube, since we thought this was the actual icon.
It’s very strange that there are 3 different icon designs in the ReVanced projects, and it seems that no one ever noticed this - but as soon as we fixed it, questions started to arise.
It seems everytime the icons are touched there is some kind of controversy.
Well, do we stick with the "wrong" sharp icon here that's been used with Manager for the past 2 years? Or do we change to the rounded (and make another PR in Patches to change to that)?
Patches repo could add one or two additional preset icons for the custom branding patch. One preset with the color ring, and maybe another with an expanded ring that was available with the prior icon design that worked with odd launcher icon shapes. But that is unrelated to the question of which icon to use.
If we can't come to a decision then we should merge what is currently here, because it is the icon style Manager has already been using the past 2 years.
Use the rounded ones, an issue should be opened for the sharp one to be fixed
I don't understand whats going on here. What issue does the branding repo have? They are all svgs, I dont understand what you mean with sharp/not sharp.
The PR body shows the diamond scaled more than current. Please use the scaling thats also used in the logo from the branding repo.
@oSumAtrIX Look at these 2 icons and finally decide which one to use? rounded or sharp?
ReVanced/revanced-branding@
main/assets/revanced-logo/revanced-logo.svgReVanced/revanced-branding@
main/assets/revanced-logo/revanced-logo-shape.svg
I do not understand what you mean. The links you sent are two different things. The shape is ONLY the shape, the round one is the full logo with the ring.
You should use the shape in scenarios where the background is configured separately, in other words:
- Create an adaptive icon background
- Extract the shape from the FULL logo from the branding, make sure the scaling is kept
- Use the extracted shape in that scale as the adaptive icon foreground
I am not sure if android does additional scaling processing so you'll have to compare with the android spec. If they do not apply any additional scaling, the final logo should look exactly like the logo from the branding.
@oSumAtrIX look carefully at those two images. They are not the same. One has rounded corners, the other is "sharp" corners. Look at the bottom point of the inner small V. The two images are different.
https://github.com/ReVanced/revanced-manager/pull/2762#issuecomment-3358407527
The non rounded icon image in the branding repo must be a mistake, because all other images are rounded. It should be fixed there, but also fixed here.
The logo here has no round circle background, since there isn't a cut shape for adaptive icons. The old manager icon did not use the correct scale and went against android guidelines. This PR fixes all of this for Manager.
I see the problem and I know why it happens.
Affinity Design handles roundness based on the canvas size. I think when I created the shape, I did those steps:
- Remove the background layer
- Scale the shape to fit the canvas
Step two scales the shape, but it does not scale the rounding value. A simple fix is to scale down the canvas to the size of the shape. This way the shape fills the entire canvas but attributes like the roundness remain correct. I will fix this.
And yes, the full logo is the "correct" one. All variations are derrivates of it
Ok seems it was caused by https://github.com/ReVanced/revanced-branding/pull/10/files
Fixed now https://github.com/ReVanced/revanced-branding/pull/31/commits/41c7155a58401eefc32acc22d23791f51148f202
I think ic_launcher_round.png can be deleted, since it is not used anywhere, it just takes up space
They can still be used in some edge cases, ~~so I think they should be kept~~ Edit: Legacy round icon can be deleted.
The files are too small to make any difference.
400x400 looks like it's much larger than needed.
But the manifest is missing the android:roundIcon declaration.
If it's gone this long and nobody has noticed it's missing in any of the edge cases, then that image should be deleted because the file isn't doing anything without the manifest declaration.
Also fix Splash screen is a broken in light mode from https://github.com/ReVanced/revanced-manager/issues/1191#issue-1873984131
For the splash screen, only the shape logos should be used
The background of the icon isn't necessary here as it's displayed directly on the app's background
I would say to use , although I admit that it would look worse for the dark mode users
I'm wondering whether an official light/dark shape icon with the diamond colored in can be made
@oSumAtrIX ?
Essentially this but with a dark V https://github.com/ReVanced/revanced-branding/blob/main/assets/revanced-logo/revanced-logo-shape.svg
ReVanced Manager would be able to do that as the branding guidelines allow for it, but ReVanced may be interested in officially including it in the branding repository?
I think this is easy to do using an attribute android:fillColor="?android:attr/textColorPrimary" in svg/xml, this is how we color the icons in the YouTube ReVanced settings.
I'm wondering whether an official light/dark shape icon with the diamond colored in can be made
Yes, sounds reasonable. I will probably get rid of the dark light variants in branding repo and just include a single color example, since you can just invert the shades depending on light or dark mode. Doing it now.
The default size is 30% (https://github.com/ReVanced/revanced-manager/pull/2762#issuecomment-3363388648), in the screenshot above I set it to 50% for the test, referring to https://github.com/ReVanced/revanced-manager/pull/2635#pullrequestreview-3176155355