bug: Manager v1.24.0 and later crash on launch with null pointer dereference

[ZargEzey]

Bug description

After updating revanced-manager to 1.24.0, it no longer launches, and instead instantly crashes. I tested the 1.25.x-dev releases and the same crash happens.

The last version that works for me is 1.23.3.

I have attached the tombstone file of the crash, hopefully it can help.

revanced-manager-1.24.0-tombstone.txt

Version of ReVanced Manager and version & name of app you are patching

1.24.0

Installation method

Regular

ReVanced Manager logs

Cannot get these logs as app instantly crashes.

Patch logs

Cannot get these logs as app instantly crashes.

Acknowledgements

• [x] I have checked all open and closed bug reports and this is not a duplicate.
• [x] I have chosen an appropriate title.
• [x] All requested information has been provided properly.
• [x] The bug is only related to ReVanced Manager.

[validcube]

Hello @ZargEzey

The problem is currently out of our control, the problem originated within Flutter Impeller Engine (which is a renderer for the app) has crashed.

So far specific GPUs from Mali, Qualcomm and potentially others are affected.

I don't have the affected devices but I'll soon send you APKs for you to test with:

• (1) Newer stable versions of Flutter, and
• (2) Latest unstable version of Flutter, and
• (3) Google Skia Engine instead of Flutter Impeller Engine.

Please use ReVanced Manager v1.23.X in the meantime.

[thepaleguy]

Im using the latest dev and i just patch spotify it works

[ZargEzey]

Hi @validcube, thanks for your reply.

The problem is currently out of our control, the problem originated within Flutter Impeller Engine (which is a renderer for the app) has crashed.

Yes I see now the issue reported in flutter, same device as I use: https://github.com/flutter/flutter/issues/164082

I don't have the affected devices but I'll soon send you APKs for you to test with:

• (1) Newer stable versions of Flutter, and
• (2) Latest unstable version of Flutter, and
• (3) Google Skia Engine instead of Flutter Impeller Engine.

I would appreciate this, they say it is fixed since flutter 3.29.2

Please use ReVanced Manager v1.23.X in the meantime.

Sure, as long as the old manager version keeps receiving the updated patches, which I think it does, this is not an urgent issue, but would be nice to be able to use latest.

Thanks again.

[martixy]

Very possibly I am experiencing the same crash.

If you need more data, I can provide logcat, but I don't know how to get the more detailed tombstone log OP gave.

I'll just revert to the older versions for now. (v1.23.3 works fine)

[ZargEzey]

Hello @validcube, thank you for your efforts on this on v1.25.0

Unfortunately I test the new release and the same crash happens, flutter is still using the Impeller Engine (I see from the crash log). Despite you putting to disabled it in Android Manifest.

I believe the solution is talked about here

The tag <meta-data android:name="io.flutter.embedding.android.EnableImpeller" android:value="false" /> should be under the <application> tag as you have put, but not nested inside another tag, and you have it inside the <activity> tag, which seems to render impeller disable option not effective.

Edit: I don't have a flutter dev environment setup to build from source but have anyhow managed to modify the AndroidManifest.xml and rebuild the 1.25.0 apk and can confirm that moving the line <meta-data android:name="io.flutter.embedding.android.EnableImpeller" android:value="false" /> out of the <activity> block and putting it just above it does indeed then disable Impeller from being used. And the app starts and runs great.

I have now made a pull request to add the change.

[validcube]

Hello @validcube, thank you for your efforts on this on v1.25.0

Unfortunately I test the new release and the same crash happens, flutter is still using the Impeller Engine (I see from the crash log). Despite you putting to disabled it in Android Manifest.

I believe the solution is talked about here

The tag <meta-data android:name="io.flutter.embedding.android.EnableImpeller" android:value="false" /> should be under the <application> tag as you have put, but not nested inside another tag, and you have it inside the <activity> tag, which seems to render impeller disable option not effective.

Edit: I don't have a flutter dev environment setup to build from source but have anyhow managed to modify the AndroidManifest.xml and rebuild the 1.25.0 apk and can confirm that moving the line <meta-data android:name="io.flutter.embedding.android.EnableImpeller" android:value="false" /> out of the <activity> block and putting it just above it does indeed then disable Impeller from being used. And the app starts and runs great.

I have now made a pull request to add the change.

Whoops, I must have short-sighted, thanks for the corrected PR.