revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

feat: Move downloader API repository as a module here

Open oSumAtrIX opened this issue 6 months ago • 3 comments

Feature description

Right now it is an independent project at https://github.com/ReVanced/revanced-manager-downloader-api. It should be moved into this repository as a Gradle module.

Motivation

The reason it is a separate repository was because it was easier to version independently. However, https://github.com/dhoulb/multi-semantic-release can achieve this in a single repository.

Acknowledgements

  • [x] I have checked all open and closed feature requests and this is not a duplicate.
  • [x] I have chosen an appropriate title.
  • [x] The feature request is only related to ReVanced Manager.

oSumAtrIX avatar May 05 '25 13:05 oSumAtrIX

I don't think this issue blocks release, so I have removed it from the release milestone. If anyone has a motivation for why this needs to be done before release, feel free to share it.

Axelen123 avatar May 05 '25 16:05 Axelen123

When packages are released moving it to this repository might create breaking changes such as the package name in the maven registry. If that's not the case, then the other reason would be that moving shouldn't take more than a couple minutes. I could look into this myself in a couple of minutes

oSumAtrIX avatar May 05 '25 16:05 oSumAtrIX

When packages are released moving it to this repository might create breaking changes such as the package name in the maven registry.

I noticed earlier when I moved the package to the other repo that you can keep using the same package name, so no breaking changes are necessary.

If that's not the case, then the other reason would be that moving shouldn't take more than a couple minutes. I could look into this myself in a couple of minutes

I am not familiar with semantic release, but if you know how to do this then go head 👍

Axelen123 avatar May 05 '25 16:05 Axelen123

This was completed months ago.

Axelen123 avatar Jul 25 '25 19:07 Axelen123