revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

feat: Set patch bundle title to patch bundle name & version

Open oSumAtrIX opened this issue 8 months ago • 12 comments

Feature description

The title can be used instead of adding a new view:

Image

Motivation

It gets rid of the generic "Patch bundle" title and saves space.

Acknowledgements

  • [x] I have checked all open and closed feature requests and this is not a duplicate.
  • [x] I have chosen an appropriate title.
  • [x] The feature request is only related to ReVanced Manager.

oSumAtrIX avatar Apr 30 '25 08:04 oSumAtrIX

What should the page then display? Instantly start displaying the patches?

Ushie avatar Apr 30 '25 10:04 Ushie

The current page is fine

oSumAtrIX avatar Apr 30 '25 10:04 oSumAtrIX

There would be no more content to display in the screen other than the View patches list item

Ushie avatar Apr 30 '25 10:04 Ushie

That's because this page is missing the patch info from the manifest of the patches file.

oSumAtrIX avatar Apr 30 '25 10:04 oSumAtrIX

Image

I redesigned it a bit according to the suggestions, and I came up with something like this. I'm very bad at UI so any feedback is appreciated.

Personally, I don't really like the bundle title as page title, I prefer it as it was before. There is also the question on how to handle long bundle names in small screen in a title, would it need to automatically resize the text?

I kinda like the last section of the page, where more information about the bundle/patches file are displayed. License and description could easily be added.

brosssh avatar May 14 '25 15:05 brosssh

The title seems kinda big? The version can be directly after the name without (). The about should be the first and auto update toggle the last.

oSumAtrIX avatar May 14 '25 17:05 oSumAtrIX

Also it seems not all metadata fields are shown in the about section. Ideally all should be shown

oSumAtrIX avatar May 14 '25 17:05 oSumAtrIX

The title seems kinda big? The version can be directly after the name without (). The about should be the first and auto update toggle the last.

The title is the same size of every other title, there is just more text so it seems bigger. It could be changed but it would not be consistent with the rest of the app. Hence why I'm not a fan of putting the bundle name in the title.

brosssh avatar May 14 '25 18:05 brosssh

Screenshot_2025-05-14-20-31-51-05_761fe8f2c59677c7476dd46708cfb34f.jpg

What about something like this?

brosssh avatar May 14 '25 18:05 brosssh

I don't see why we should have two titles. Replacing "Patch Bundle" with the patch name is fine

oSumAtrIX avatar May 30 '25 12:05 oSumAtrIX

You can omit the version. Just the name from the manifest is fine

oSumAtrIX avatar May 30 '25 12:05 oSumAtrIX

I don't see why we should have two titles. Replacing "Patch Bundle" with the patch name is fine

How to handle long names? The current name already wouldn't fit, but it's also possible to have even longer names. I guess it's maybe possible to auto resize the text or either make a new line, but this would generate inconsistency between other screens..

brosssh avatar May 31 '25 07:05 brosssh