ReVanced
bug: Version format differns when adding bundle from local storage
Bug description
No "v" present here, for example:
Acknowledgements
- [x] I have checked all open and closed bug reports and this is not a duplicate.
- [x] I have chosen an appropriate title.
- [x] All requested information has been provided properly.
- [x] The bug is only related to ReVanced Manager.
Are you sure this is explicitly local storage? I think it may be that the ReVancedExperiments patch bundle actually has that bundle version without the v, I don't seem to find ReVanced Manager to be doing any kind of alteration to the version string
How should ReVanced Manager fix this? Should it read the version value from the downloaded file and stop reading the value from the API?
API takes info from tags. Perhaps it should read the patches files manifest?
But in this case calling https://api.revanced.app/v4/patches needs the API to download the patches, and read the manifest that way (once)
However, the API should be used by manager in the update screen for example. It does not need to be used in the patches list screen. There the manifest should be read
API takes info from tags. Perhaps it should read the patches files manifest?
But in this case calling https://api.revanced.app/v4/patches needs the API to download the patches, and read the manifest that way (once)
A simpler solution would be to make semantic-release not add v to the version: https://semantic-release.gitbook.io/semantic-release/usage/configuration#tagformat
I don't see any benefit to adding the v and removing it will make the version strings match exactly, which is good, since it means the API and release infrastructure will no longer be "lying" about the version.
This adds inconsistency with other repos or requires changing it for all other repos introducing a non obvious change for a reason unrelated to them. Besides, regardless of that manager should read info for the patches from the patches manifest. That's what its for.