revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

build: Code analysis, styling enforcement

Open validcube opened this issue 8 months ago • 1 comments

Currently in Compose variant, styles are inconsistent with almost every files.

A viewmodel might be defined as vm, while some files might defined literally as viewModel

https://github.com/ReVanced/revanced-manager/blob/compose-dev/app/src/main/java/app/revanced/manager/ui/screen/settings/AdvancedSettingsScreen.kt#L64

https://github.com/ReVanced/revanced-manager/blob/compose-dev/app/src/main/java/app/revanced/manager/ui/screen/settings/GeneralSettingsScreen.kt#L45

Some of the files are importing using star import (import *) while at the same time importing each every entities. Some code editor by default enforce changing star import to individual import like as seen on:

https://github.com/ReVanced/revanced-manager/pull/2421/files#diff-4316f1a9d3abbb8ff718f8eaf53828f708cf56c11c2c28924b4addce1e3f848eR10-R15

https://github.com/ReVanced/revanced-manager/pull/2422/files#diff-5d8eef944c2d224a454e6414c1a0a90b057c4a1336b19fcde0632bd0856a8feaR33-R38

...

And there might be more inconsistencies not listed in this issue.

validcube avatar Feb 12 '25 15:02 validcube