revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard
verified publisher icon ReVanced

feat: Add confirm dialogs when toggling dangerous settings

Open oSumAtrIX opened this issue 1 year ago • 4 comments

Feature description

Right now safeguards for example can be simply toggled (even accidentally):

image

When toggling them yet another warning should be shown to clarify why it is unsuggested.

Motivation

The user might toggle them without knowing that they shouldnt.

Acknowledgements

  • [X] This issue is not a duplicate of an existing feature request.
  • [X] I have chosen an appropriate title.
  • [X] The feature request is only related to ReVanced Manager

oSumAtrIX avatar Jul 13 '24 21:07 oSumAtrIX

Should this be the expected behavior?

https://github.com/user-attachments/assets/8f3df7c0-bde5-4190-9e56-ee3e1474ffa6

TheAabedKhan avatar Jul 20 '24 09:07 TheAabedKhan

"Require suggested app version" is on by default, so the dialog should be shown when it goes from true -> false

Axelen123 avatar Jul 20 '24 09:07 Axelen123

Fixed✅

TheAabedKhan avatar Jul 20 '24 13:07 TheAabedKhan

Open a PR so we can review

Ushie avatar Jul 20 '24 13:07 Ushie