revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: Safeguard does not account for patch options

Open oSumAtrIX opened this issue 1 year ago • 2 comments

Bug description

The warning and safeguard should not allow changing options:

image

But it is still possible to enter and change options:

image

Acknowledgements

  • [X] This issue is not a duplicate of an existing bug report.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.
  • [X] The bug is only related to ReVanced Manager

oSumAtrIX avatar Jul 13 '24 21:07 oSumAtrIX

I don't remember why the dialog mentions patch options at all. Why shouldn't the user be allowed to change patch options? Didn't you say that it should be allowed because changing patch options is intended design?

Axelen123 avatar Jul 13 '24 21:07 Axelen123

Why shouldn't the user be allowed to change patch options

Lets say there's a patch which by default changes the logo. The logo option requires a path to a file. If the user now changes it to something random, the patch would fail. It is encouraged to use the default options unless explicitly confirmed with the user that they don't want that.

oSumAtrIX avatar Jul 13 '24 21:07 oSumAtrIX