revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

fix(ui): Adjust scroll from clipping children form fields in `AlertDialog` from `showSourcesDialog` (#1748)

Open Domenic-MZS opened this issue 1 year ago • 2 comments

🔧🎨 UI Fix: Adjust Scroll from clipping it's children form fields in the AlertDialog from showSourcesDialog (#1748)

This PR closes #1748

Overview

The AlertDialog's scrolling behavior for showSourcesDialog was causing children to clip, affecting user experience and readability, especially on devices with small screens or large fonts.

  • Issue: Children (form fields) were clipping within the AlertDialog.
  • Context: The structure for managing scrolling behavior was not efficient, leading to readability issues.
  • Related Solutions: No similar solution available.
  • Impact: Enhances readability and usability on various devices, ensuring a smoother user experience. (For smaller devices & devices with large fonts).

📓 Description

This PR addresses the issue of children clipping within the AlertDialog by adjusting the structure to handle scrolling more efficiently. It removes unnecessary scroll components and enables the builtin scroll handle from the Flutter AlertDialog, ensuring content within the dialog is properly displayed without clipping.

✍🏼 Changes Made

  • Removed child SingleChildScrollView.
  • Added parent dialog's scrollable property to true.

🦯 Testing

  • [x] ~Update Tests (ToDo - Not Found nor needed for now...)~
  • [x] Compile/Build code
    • 🐞 Tested with Stable Flutter v3.19.3 and dart 3.3.1.
    • System: Linux archlinux 6.7.9-arch1-1 GNU/Linux

📋 Notes & References

🔬 Reviewers

N/A (any mod is ok)


👾 Feedback, changes, or suggestions are welcome! ✌🏼 🏖️ now a 🍕 emoji too...

Domenic-MZS avatar Mar 23 '24 21:03 Domenic-MZS

⚒️ Build status

✅ Succeeded build on 22272c3.

Details: 8404775438!

⚙️ Workflow run configuration

  • Flutter cache: true
  • App flavor: release

github-actions[bot] avatar Mar 23 '24 22:03 github-actions[bot]

⚒️ Build status

✅ Succeeded build on 22272c3.

Details: 8404775438!

⚙️ Workflow run configuration

  • Flutter cache: true
  • App flavor: release

Note to team

[!CAUTION] DO NOT use the PR builder tool, this is affected by

  • #1540 Which causes the CI not to include the changes from the PR.

validcube avatar Mar 23 '24 23:03 validcube