revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: Slight clipping in `Alternative sources` setting

Open ILoveOpenSourceApplications opened this issue 4 months ago • 4 comments

Bug description

If the user is typing or editing the value and has their keyboard open in the Patches organization box, the title clips into the padding. Screenshot_20240306_153035_ReVanced Manager

Version of ReVanced Manager and version & name of app you are patching

v1.19.1

Installation method

Regular

ReVanced Manager logs

Nil

Patch logs

No response

Acknowledgements

  • [X] This issue is not a duplicate of an existing bug report.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.
  • [X] The bug is only related to ReVanced Manager

The clipping does not occur for me.

oSumAtrIX avatar Mar 06 '24 18:03 oSumAtrIX

How's it showing up for you? Can you share a screen shot?

I am now able to reproduce when opening the keyboard, previously I had the keyboard closed, mb

oSumAtrIX avatar Mar 06 '24 18:03 oSumAtrIX

Seems like a clipping issue of the Dialog (Widget) having a nested SingleChildScrollView (Widget) thing... It'll be fixed if the parent (Dialog) handles the scroll and not the child (SingleChildScrollView).

Lemme fix this real quick 😀

EDIT: 👾 Despite how it sounds, these changes should maintain the same effect and look alike the current implementation (without the clipping and extra scroll, though).

Domenic-MZS avatar Mar 23 '24 19:03 Domenic-MZS