revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

Published 20 hours ago • verified publisher icon ReVanced

chore: Merge `dev` to `main`

Open Ushie opened this issue 1 year ago • 8 comments

Fixes #1325, closes #1629, fixes #530

Ushie avatar Dec 31 '23 00:12 Ushie

Also would it be possible to publish the release as ReVanced Bot?

validcube avatar Jan 27 '24 00:01 validcube

Yeah, a token can be created for this for the bot

oSumAtrIX avatar Jan 27 '24 00:01 oSumAtrIX

Also by the way

@BenjaminHalko can you please look into the PopScope changes?

See

  • #1645

validcube avatar Jan 27 '24 00:01 validcube

Fyi, whenever semantic release has created a tag, force push is discouraged.

validcube avatar Jan 29 '24 09:01 validcube

Force pushing should be avoided regardless. It is not a huge problem, though, even with semantic release. Once you force push, semantic-release will not attempt to regenerate a new commit/tag, as long as the commits and tags are preserved. The issue that occurred here is caused by the force push deleting a commit generated by semantic release, without deleting the tag, so semantic release attempts to regenerate the commit and the tag and fails because it exists already

oSumAtrIX avatar Jan 29 '24 10:01 oSumAtrIX

Docs and CI check are done now, will moving on to code check after PR have been merged.

  • #1663
  • #1662

validcube avatar Feb 01 '24 23:02 validcube

Yeah, a token can be created for this for the bot

Can get started on doing that, is there any organisation secret that I could use here.

validcube avatar Feb 25 '24 02:02 validcube

@validcube Here is a secret named REPOSITORY_PUSH_ACCESS

oSumAtrIX avatar Feb 25 '24 03:02 oSumAtrIX

@validcube Here is a secret named REPOSITORY_PUSH_ACCESS

Hm, the secret appear to be empty, could you verify that it's correctly set?

https://github.com/ReVanced/revanced-manager/actions/runs/8135888633/job/22231203031

validcube avatar Mar 04 '24 04:03 validcube

@validcube Try now

oSumAtrIX avatar Mar 04 '24 06:03 oSumAtrIX

This release, will completely obliterate the changelog.

validcube avatar Mar 04 '24 13:03 validcube

OH WE'RE PUSHING NOW, REAL MEN TEST IN PRODUCTION

validcube avatar Mar 04 '24 15:03 validcube

If you merge, you're going to find your pet hidden in a funny hole at a random north korea graveyard

Ushie avatar Mar 04 '24 15:03 Ushie

If you merge, you're going to find your pet hidden in a funny hole at a random north korea graveyard

Not the cat :(

validcube avatar Mar 04 '24 15:03 validcube

I don't have enough experience with flutter UI to solve the ongoing UI issues caused by longer strings, I'll merge this for now to get the important fixes in and assign someone else to it

Ushie avatar Mar 05 '24 00:03 Ushie