revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

feat: Add "(root)" to "mount" install option and "(non-root)" to "install" option

Open JL102 opened this issue 1 year ago • 6 comments

Feature description

When clicking install after patching, a dialog opens with "install" and "mount". I am proposing that the text be changed to "install (non-root)" and "mount (root)" or "mount (requires root)".

Motivation

The "mount" / "insfall" install methods are not quite clear, and I only found out that they are the root/nonroot method after I clicked them. It would be helpful if the text inside the selection dialog included the type of installation so that the user knows what it is before selecting one.

Additional context

No response

Acknowledgements

  • [X] This request is not a duplicate of an existing issue.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.
  • [X] The issue is solely related to the ReVanced Manager

JL102 avatar Nov 28 '23 15:11 JL102

Just adding (Root) to the mount option should be enough

oSumAtrIX avatar Nov 28 '23 15:11 oSumAtrIX

@oSumAtrIX, our new dialog that has an explanation for the methods should be enough to close this issue. What do you think?

TheAabedKhan avatar Nov 28 '23 16:11 TheAabedKhan

I don't remember the dialog, what does it say?

oSumAtrIX avatar Nov 28 '23 16:11 oSumAtrIX

I just checked it. It doesn't mention root or non-root terms. So, I think we need a separate PR for this. Or should we edit the strings on the existing PR?

TheAabedKhan avatar Nov 28 '23 16:11 TheAabedKhan

Add option to mout or install(root) patched apk from sdcard.

ask9027 avatar Dec 12 '23 12:12 ask9027

Agreed it needs better wording. I had to Google what it meant the first time I saw the option.

neo-neo1 avatar Mar 28 '24 22:03 neo-neo1

ReVanced Manager will soon be released as a full rewrite. Over time, many feature requests have been made for the current version of ReVanced Manager, but to accelerate the development of the new version of ReVanced Manager, we have to focus on it, which I am closing this issue according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long/ Low priority/ Maintainers un-interested/ Too complex to realize
  • Feature planned/ already implemented for the new version of ReVanced Manager
  • Already implemented

Regardless, anyone who comes across this feature request can PR it to the current version of ReVanced Manager until the new version is ready. Thanks for your feature request!

oSumAtrIX avatar Jun 17 '24 20:06 oSumAtrIX