revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

feat: warn against split apk from storage

Open Martinligabue opened this issue 1 year ago • 11 comments

Feature description

The manager should be able to recognize split apk, apart from the version.

Another way would be to explain the users where to download the apk that's not split

Motivation

I might download the exact version of YouTube, and the patching will fail because it's split

Additional context

I had no clue these things existed, and even if the manager was saying that the version was good, I couldn't patch the youtube app, so I opened an issue here: https://github.com/ReVanced/revanced-patches-template/issues/244

They said I have to report here

Acknowledgements

  • [X] This request is not a duplicate of an existing issue.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.
  • [X] The issue is solely related to the ReVanced Manager

Martinligabue avatar Oct 07 '23 19:10 Martinligabue

Not sure how much it is the task of ReVanced Manager to do that.

oSumAtrIX avatar Oct 07 '23 19:10 oSumAtrIX

Not sure how much it is the task of ReVanced Manager to do that.

It is equivalent to the warning that's shown when selecting an installed app

Ushie avatar Oct 07 '23 19:10 Ushie

The warning is also not correct. An installed application can be patched, only splits can not be.

oSumAtrIX avatar Oct 07 '23 19:10 oSumAtrIX

The warning isn't shown if the installed app isn't split

Ushie avatar Oct 07 '23 19:10 Ushie

Alright

oSumAtrIX avatar Oct 07 '23 19:10 oSumAtrIX

I did not get any warning.

I saw it asked for a version trying to patch yt, I went to Aurora, downloaded the right version and now it seemed that everything was ok, it even went all the way patching everything, until the repacking.

Martinligabue avatar Oct 07 '23 19:10 Martinligabue

Did you install it on Aurora store and then select it? I might've misinterpreted the issue if so

Ushie avatar Oct 07 '23 20:10 Ushie

yes, I just chose the manual download to download a specific version instead of the latest.

but as they answered in the other issue, that results in a split apk, whatever that means, so it's not a viable option to install a YouTube apk that this patcher likes. (The only way is to search for it online from third parties who repackage it as a single apk, afai understand?)

Martinligabue avatar Oct 07 '23 20:10 Martinligabue

The latest version requires v18.38.44 which is available for download only as xapk and manager can't use this type of file. Waiting for a newer version...

sigma2017 avatar Oct 14 '23 08:10 sigma2017

It's available as .apk on APKMirror

Ushie avatar Oct 14 '23 08:10 Ushie

Google has now stopped providing fat APKs for sideloading on the Play Store. Consequently, most third-party websites that used to provide application packages have also stopped providing .apk, instead providing split APKs, which cannot be directly patched by ReVanced Manager.

mitian233 avatar Aug 09 '24 03:08 mitian233