revanced-manager
revanced-manager copied to clipboard
ReVanced
feat: add social links
A future PR may follow up on our past conclusion regarding hardcoding the app's branding here and move the dynamic part implemented here to the API screen. The concluded reason above was that despite changing the API, the app itself is still vendored by us and, therefor, branded with our links and whoever wants to change the branding has to fork the app and vendor it themselves with their branding. In contrast, the API can deliver additional information about the API in the API settings page.
Apart from that the PR lgtm!
The concluded reason above was that despite changing the API, the app itself is still vendored by us and, therefor, branded with our links and whoever wants to change the branding has to fork the app and vendor it themselves with their branding.
This sounds perfectly reasonable to me, even if the API is changed you still are using our app, in which case should always use our branding
I personally see no need in adding an About screen that is strictly for the API, that would be rather odd and I'm not particularly sure how we would approach that
How would it look? where would it be placed?
I have mentioned where this can be added:
In contrast, the API can deliver additional information about the API in the API settings page.
When you use an API, mentioning their information to signify that you are now consuming from them and where to reach out for issues and other reasons is useful. This is furthermore clarified in my previous comment https://github.com/ReVanced/revanced-manager/pull/1294#discussion_r1335091034
Is there anyway to stop the Filled Buttons from taking all the available width? it looks odd
We could always increase the side padding, but there is no way to make it use the minimum space possible while also having the buttons be the same size. The fact that the buttons were the same size before was just a coincidence.