revanced-library icon indicating copy to clipboard operation
revanced-library copied to clipboard

feat: release advanced patch option types

Open Ushie opened this issue 2 years ago • 8 comments

Feature description

Introduce Patch Option Types such as Color, which extend on ReVanced Patcher types

Motivation

The ability to use the best-fitting UI for patch options in GUI frontends, while keeping only the necessary types in ReVanced Patcher which has refused to implement these types

Additional context

Perhaps this can be moved to ReVanced Library

Acknowledgements

  • [X] This request is not a duplicate of an existing issue.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.
  • [X] The issue is solely related to the ReVanced Manager

Ushie avatar Nov 19 '23 20:11 Ushie

The option types should be structured in it's own Gradle subproject. The subproject is to be then released as a maven package. Patches then have to shade the classes, otherwise they will not work outside of ReVanced Manager because the types would be missing

oSumAtrIX avatar Nov 19 '23 20:11 oSumAtrIX

This can be moved to the ReVanced Library repository @oSumAtrIX

Ushie avatar Jan 10 '24 09:01 Ushie

Please open a new issue, this one specifically requests ReVanced Manager patch options and not general advanced types

oSumAtrIX avatar Jan 10 '24 09:01 oSumAtrIX

No longer an issue, solved

Ushie avatar Jan 10 '24 09:01 Ushie

Which abstract types are needed?

oSumAtrIX avatar Jan 10 '24 09:01 oSumAtrIX

  • [ ] File
  • [ ] Directory
  • [ ] Color
  • [ ] General types like Number

Those are the ones I can state of the top of my head, @PalmDevs may have more to add

Ushie avatar Jan 10 '24 09:01 Ushie

Former 3 will abstract String but former 2 can abstract File. For the last one, decimal and integral numbers are supported as primitive types already.

oSumAtrIX avatar Jan 10 '24 10:01 oSumAtrIX

Also include resource name which will abstract String. Eg. @android:color/black.

PalmDevs avatar Jan 10 '24 12:01 PalmDevs