revanced-integrations icon indicating copy to clipboard operation
revanced-integrations copied to clipboard

feat: disable sponsorblock on shorts

Open OxrxL opened this issue 3 years ago • 6 comments

OxrxL avatar Sep 07 '22 22:09 OxrxL

There are a lot of changes, that were not necessary. The sponsorblock patch only injects couple of calls to methods into the application, only these methods should be blocked.

I need to know which are these methods, otherwise it will become quite difficult for me to find out

ghost avatar Sep 14 '22 18:09 ghost

Sure, all calls to the methods in the integrations can be found here. Simply CTRL+F and search for integrations/ to get a good understanding.

oSumAtrIX avatar Sep 15 '22 00:09 oSumAtrIX

Sure, all calls to the methods in the integrations can be found here. Simply CTRL+F and search for integrations/ to get a good understanding.

At first look I should find an unused register for each call. It does not make the operation more complex?

ghost avatar Sep 15 '22 00:09 ghost

Sure, all calls to the methods in the integrations can be found here. Simply CTRL+F and search for integrations/ to get a good understanding.

Nevermind. I said nonsense. You were referring to the changes to be made to the integrations, and not to the patch. xD

ghost avatar Sep 15 '22 01:09 ghost

No problem, yeah, simply add the condition in the integrations methods instead of patching the application.

oSumAtrIX avatar Sep 15 '22 01:09 oSumAtrIX

Should be good now. For safeness, test it you too. :D

ghost avatar Sep 15 '22 01:09 ghost

:tada: This PR is included in version 0.40.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Sep 21 '22 01:09 github-actions[bot]