revanced-cli icon indicating copy to clipboard operation
revanced-cli copied to clipboard

fix: listing patches requires input apk

Open Itroublve opened this issue 3 years ago • 7 comments

Fixes #87

Itroublve avatar Jul 10 '22 19:07 Itroublve

You have to add a second commit to this that does nothing. Otherwise your PR can't be squashed :(

TheJeterLP avatar Jul 10 '22 19:07 TheJeterLP

or just have a semantic commit in the first place

bogadana avatar Jul 10 '22 19:07 bogadana

You should add a way of not providing an APK but providing the package name as a string. There might be some applications where the package name gets changed in a rooted phone too

TheJeterLP avatar Jul 10 '22 21:07 TheJeterLP

The code looks like it is working around the current code and should instead be adjusted to properly support this feature.

oSumAtrIX avatar Jul 10 '22 22:07 oSumAtrIX