bug: unmount does not work

[laur89]

Bug description

Unmount operation claims app is unmounted, yet mountpoint is still present in /proc/mounts.

1. pre-unmount state, soundcloud is mount-installed:

$ adb shell su -c "grep soundcloud /proc/mounts"
/dev/block/dm-44 /data/app/~~f7qZNop8S0IwBTRteV7Wdw==/com.soundcloud.android-NQYsI6SVP_Ey6JDJJvGHZg==/base.apk f2fs rw,lazytime,seclabel,nosuid,nodev,noatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,flush_merge,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,resuid=0,resgid=1065,inlinecrypt,alloc_mode=default,checkpoint_merge,fsync_mode=nobarrier,memory=normal 0 0
/dev/block/dm-44 /data/incremental/MT_data_app_vmdl183/mount/st_13_1/com.soundcloud.android-NQYsI6SVP_Ey6JDJJvGHZg==/base.apk f2fs rw,lazytime,seclabel,nosuid,nodev,noatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,flush_merge,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,resuid=0,resgid=1065,inlinecrypt,alloc_mode=default,checkpoint_merge,fsync_mode=nobarrier,memory=normal 0 0

2. unmount operation:

$ java -jar ./revanced.jar  utility uninstall --package-name com.soundcloud.android --unmount
WARNING: No device serial supplied. Using device with serial a7b1a22a 
INFO: Uninstalling com.soundcloud.android by unmounting 
INFO: Uninstalled the patched APK file 

3. verify whether the operation succeeded, we're expecting no matches:

$ adb shell su -c "grep soundcloud /proc/mounts"
/dev/block/dm-44 /data/app/~~f7qZNop8S0IwBTRteV7Wdw==/com.soundcloud.android-NQYsI6SVP_Ey6JDJJvGHZg==/base.apk f2fs rw,lazytime,seclabel,nosuid,nodev,noatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,flush_merge,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,resuid=0,resgid=1065,inlinecrypt,alloc_mode=default,checkpoint_merge,fsync_mode=nobarrier,memory=normal 0 0
/dev/block/dm-44 /data/incremental/MT_data_app_vmdl183/mount/st_13_1/com.soundcloud.android-NQYsI6SVP_Ey6JDJJvGHZg==/base.apk f2fs rw,lazytime,seclabel,nosuid,nodev,noatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,flush_merge,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,resuid=0,resgid=1065,inlinecrypt,alloc_mode=default,checkpoint_merge,fsync_mode=nobarrier,memory=normal 0 0

Yet mountpoints are still there?

---

$ java -jar ./revanced.jar --version
ReVanced CLI v5.0.1

Acknowledgements

• [x] I have checked all open and closed bug reports and this is not a duplicate.
• [x] I have chosen an appropriate title.
• [x] All requested information has been provided properly.

[oSumAtrIX]

Thats odd. The unmount command should be ran correctly, but the issue implies its not.

[laur89]

Could this be caused by the fact I'm mounting apk-s that have been created by merging split apks pulled from playstore-installed instances?

[oSumAtrIX]

Mounting/unmounting files has nothing to do with APKs per se, but files so I don't think so.

[laur89]

Haven't touched the revanced-installed apps since May, and now discovered that none of them are listed under /proc/mounts anymore. Is Android pulling something weird here?

[oSumAtrIX]

I do not know what you mean

[laur89]

I do not know what you mean

I have installed packages A, B, and C via revanced mount (months ago, when they surely were seen under /proc/mounts), but

$ adb shell su -c "grep -i  'A' /proc/mounts"
$ adb shell su -c "grep -i  'B' /proc/mounts"
$ adb shell su -c "grep -i  'C' /proc/mounts"

now return nothing.

[oSumAtrIX]

Try mount | grep A

[laur89]

Exactly the same. And yet the programs are there and working fine (well, apart from YT that needs updating due to api changes)

[oSumAtrIX]

Well, ReVanced just places scripts that call mount. The rest is up to your OS, unsure whats going on on your end.