revanced-cli icon indicating copy to clipboard operation
revanced-cli copied to clipboard

feat: Add signature checks

Open oSumAtrIX opened this issue 1 year ago • 0 comments

Feature description

Depends on https://github.com/ReVanced/revanced-library/issues/61

A signature should accompany each patch file. This can be achieved via an ArgGroup. The current patch file option can be moved into an arg group accompanied by an optional signature option. The keyring can be supplied via an option next to the ArgGroug. If the signature is missing or invalid, the patch should abort. Another option can be added to skip signature checks. A warning should always be shown if the signature check failed or was skipped. Example:

java -jar cli.jar patch -b patches.rvp -s patches.rvp.asc -b patches2.rvp -k revanced.gpg

A new utility subcommand should be added regarding the signatures.

Motivation

Same as https://github.com/ReVanced/revanced-manager/issues/2082

Acknowledgements

  • [X] This issue is not a duplicate of an existing feature request.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.

oSumAtrIX avatar Aug 08 '24 17:08 oSumAtrIX