revanced-api icon indicating copy to clipboard operation
revanced-api copied to clipboard

refactor!: rename `socials` to `connections`

Open validcube opened this issue 1 year ago • 3 comments

I didn't update Qodana because I have no idea how to use it... well I do know how to use it but I ran into issue with performance

fix #106

validcube avatar Dec 17 '23 12:12 validcube

This is a breaking change, meaning you can't push this change to /v2/

And seeing that it's not particularly a necessary change either, the PR may be better off closed in my opinion, the issue should be updated to target v3 milestone

Ushie avatar Dec 17 '23 12:12 Ushie

In the config.py file what you would do is:

# API Versioning

api_versions: dict[str, list[str]] = {
    "old": ["compat"],
    "v2": [
        "announcements",
        "donations",
        "github",
        "info",
        "login",
        "ping",
        "socials",
        "manager",
    ],
    "v3": [
        "announcements",
        "donations",
        "github",
        "info",
        "login",
        "ping",
        "connections",
        "manager",
    ]
}

The API lacks a straightforward way to provide multiple versions of the same endpoint atm, I am working on that for the next feature pack.

alexandreteles avatar Jan 16 '24 18:01 alexandreteles

In the config.py file what you would do is:

# API Versioning

api_versions: dict[str, list[str]] = {
    "old": ["compat"],
    "v2": [
        "announcements",
        "donations",
        "github",
        "info",
        "login",
        "ping",
        "socials",
        "manager",
    ],
    "v3": [
        "announcements",
        "donations",
        "github",
        "info",
        "login",
        "ping",
        "connections",
        "manager",
    ]
}

The API lacks a straightforward way to provide multiple versions of the same endpoint atm, I am working on that for the next feature pack.

👍 Done

validcube avatar Jan 17 '24 10:01 validcube

Superseded by https://github.com/ReVanced/revanced-api/pull/169, thanks

oSumAtrIX avatar Jul 08 '24 12:07 oSumAtrIX