rescience.github.io icon indicating copy to clipboard operation
rescience.github.io copied to clipboard

blob or raw URL for pdfs?

Open oliviaguest opened this issue 7 years ago • 6 comments

I was just adding an article to the website and noticed that in the list (here: https://rescience.github.io/read/) some of the links to PDFs go to the .../blob/... and some to the .../raw/... directory/URL.

Blob does this (the the PDF preview being rendered by GH): https://github.com/ReScience-Archives/Stollmeier-2017/blob/master/article/Stollmeier-2017.pdf

While raw does this (direct link to the file, so in my browser it opens a dialogue to save the PDF): https://github.com/ReScience-Archives/Stollmeier-2017/raw/master/article/Stollmeier-2017.pdf

Which is the "right" one? Or do we not mind?

oliviaguest avatar Aug 30 '17 12:08 oliviaguest

There are good arguments for either one. My personal preference is linking to raw, which is how pretty much everyone outside the GitHub universe presents links to PDF.

khinsen avatar Aug 30 '17 13:08 khinsen

It's a mix of both now — do we want to be consistent?

oliviaguest avatar Aug 30 '17 13:08 oliviaguest

I'd say yes, but before we change anything we need to agree on this (vote?)

khinsen avatar Aug 30 '17 13:08 khinsen

I vote raw.

oliviaguest avatar Aug 30 '17 13:08 oliviaguest

Blob also doesn't seem to work on mobile phones. At least a couple of Android mobile phones we tried on.

fa-ahmad avatar Mar 25 '20 09:03 fa-ahmad

Did we do it in the end ?

rougier avatar Mar 30 '20 07:03 rougier