SessionSync icon indicating copy to clipboard operation
SessionSync copied to clipboard

Duplicate tabs are not saved.

Open 532910 opened this issue 6 years ago • 7 comments

532910 avatar Apr 23 '18 15:04 532910

Ok... I did that on purpose. I thought that makes no sense to actually store duplicate tabs that have the same url. Do you not consider it a normal behavior ? I suppose I can add an option to ignore duplicate tabs, I guess.

ReDEnergy avatar Apr 23 '18 15:04 ReDEnergy

Session must be restored (and saved) exactly the same it is. With all pinned tabs, exactly the same order and number of tabs with all it's history.

532910 avatar Apr 23 '18 15:04 532910

If you put it that way I suppose you're right. Probably that's the default behavior everyone will expect even though they might have duplicate tabs. I'll make sure it will be like this.

ReDEnergy avatar Apr 23 '18 15:04 ReDEnergy

Fixed in version 3.0.1 - 544850e Release available on AMO

ReDEnergy avatar Apr 26 '18 23:04 ReDEnergy

Though this is a good fix for default behavior, is that be possible to add a button to deduplicate the tabs in a session?

qqldd avatar Aug 11 '19 19:08 qqldd

@qqldd Not sure I do get what your requesting. To add a button in the session toolbar to delete all the tabs that are duplicated and leave only 1 copy of each one ? Basically, exactly what was before 3.0.1 ? Well.. I suppose I can do this, or add an option to disable saving of duplicate tabs just as it was previously. Do you have a preference between an option (would change the saving all the time) or a toolbar action (only on demand to "De-duplicate a session"). Or probably If it's not too complicated I will add both. It's true that the action would not create any additional performance cost so I prefer doing only that but I will think about it.

ReDEnergy avatar Aug 11 '19 21:08 ReDEnergy

Yes, the functionality is like before 3.0.1.

I think an option or a button or both is okay. Thanks for quickly respond to this!

qqldd avatar Aug 12 '19 04:08 qqldd