RcppParallel icon indicating copy to clipboard operation
RcppParallel copied to clipboard

System tbb autodetection

Open Enchufa2 opened this issue 4 years ago • 4 comments

Would you be interested in this? I.e., a piece of code that detects tbb and sets TBB_LIB and TBB_INC automatically. If so,

  • I can work on this (low priority, for a future release).
  • What's the proper place for this? I'm willing to contribute the Unix version, and thus the most natural way for this would be shell code in the configure script.

Enchufa2 avatar Apr 13 '21 08:04 Enchufa2

I would definitely welcome that.

RcppParallel uses configure for configuring (I wrote an R package for this because of how much I hate writing shell / autoconf scripts), so the right place to add this auto-configure code would be around here:

https://github.com/RcppCore/RcppParallel/blob/master/tools/config/configure.R

Note that this runs on both Windows + Unix by default, so you'd want to shield with .Platform$OS.type or something similar for unix-specific stuff.

kevinushey avatar Apr 14 '21 18:04 kevinushey

Perfect, I'll prepare a PR when I find some time.

Enchufa2 avatar Apr 14 '21 18:04 Enchufa2

Is this still something worth exploring?

kevinushey avatar Dec 22 '21 05:12 kevinushey

Yes, please keep this open. Apologies for the delay.

Enchufa2 avatar Dec 22 '21 08:12 Enchufa2