resvg icon indicating copy to clipboard operation
resvg copied to clipboard

Invalid blur clipping

Open JoKalliauer opened this issue 4 years ago • 4 comments

svg

svg

png

ink rsvg resvg
Vector saturn Vector saturn_r Vector saturn_re

Expected

PNG

Copyright

source https://commons.wikimedia.org/wiki/File:Vector_saturn.svg

author Kelvinsong

license https://creativecommons.org/licenses/by-sa/3.0/deed.de

JoKalliauer avatar Feb 27 '20 20:02 JoKalliauer

Looks like everyone is wrong:

Vector_saturn

Will investigate further to find the source of the issue.

RazrFalcon avatar Feb 27 '20 22:02 RazrFalcon

@RazrFalcon Hi! I try use your implementation of fastblur and saw same effect fix for me was in box_blur_vert change initialization of fv, lv

let fv: RGBA8 = backbuf[ti];
let lv: RGBA8 = backbuf[ti + width * (height - 1)]; 

in box_blur_horz change change initialization of fv, lv

let fv: RGBA8 = backbuf[ti];
let lv: RGBA8 = backbuf[ti + width - 1];

ps. sorry don't have enough time to PR

matpaul avatar Jun 15 '21 22:06 matpaul

Thanks, will try it out.

RazrFalcon avatar Jun 15 '21 22:06 RazrFalcon

Hi, @RazrFalcon

I think the Blur filter might be a separate issue. We have encountered this problem in our actual business.

Fixed with the code suggested by @matpaul (see https://github.com/zimond/resvg/commit/cab0b158e00209cf8e89ef00bbe5f5e1782417eb).

Can we fix the Blur filter issue https://github.com/RazrFalcon/resvg/issues/324 first?

Test case(svg):

yisibl avatar Apr 21 '22 08:04 yisibl

resvg produces the correct output according to the SVG spec here.

The image border blur was fixes in v0.33

RazrFalcon avatar May 21 '23 13:05 RazrFalcon

confirm fix

Vector_saturn_rendersvg

JoKalliauer avatar May 31 '23 05:05 JoKalliauer