japp icon indicating copy to clipboard operation
japp copied to clipboard

Fix: Player disconnect messages don't display (duplicate) client number

Open Razish opened this issue 9 years ago • 4 comments

for duplicate names (i.e. multiple Padawan players) it should show the name we substitute it with

Razish avatar Sep 30 '15 15:09 Razish

If the message is coming from the server engine, it will not show because its not updated in the engine I think.

ensiform avatar Sep 30 '15 19:09 ensiform

the name substitution doesn't work anyway. the numbers all get cleared on map change and then everyone has the same name again.

On Wed, Sep 30, 2015 at 12:57 PM Ensiform [email protected] wrote:

If the message is coming from the server engine, it will not show because its not updated in the engine I think.

— Reply to this email directly or view it on GitHub https://github.com/Razish/japp/issues/332#issuecomment-144521894.

dpadgett avatar Sep 30 '15 23:09 dpadgett

Right. But the number gets added in ClientUserinfoChanged but never sent back to the engine which is why the disconnect message only says the original name.

ensiform avatar Oct 01 '15 03:10 ensiform

I think mods should be able to control the message to be honest.

Maybe a flag in new api that says if mod handles it or not.

ensiform avatar Oct 01 '15 23:10 ensiform