i3lock-color
i3lock-color copied to clipboard
Raymo111
Display modifier key warning before unlocking, too
Original commit at i3lock: https://github.com/i3/i3lock/commit/deaf8b9f0f8193b92bdf7f7631f82471296812d1
No braking changes
Progression to solving #[201] as this commit DOES NOT have any braking changes
Description
- Allows to know if the keyboard modifiers are on before checking for the password. Before that, you would know if u had CAPS_LOCK and/or others modifiers active only when you pressed enter to check for your password
Release notes
Notes:
- Display modifier key warning before unlocking, too
Marked this as WIP for now, unmark it and request review when you're done please 🙂
yeah for the wip i was going to make another pull request because of breaking changes and bump up in version. That's why the revert. I commited into another branch. So they don't interfere
@Raymo111 removed the wip, whenever u are ready
The breaking changes are the in the https://github.com/Raymo111/i3lock-color/pull/287 pull request so it can be already pushed into master.
@Raymo111 oh thx for letting me notice it Apparently I didn't notice that the revert I made also reverted the good commit This first one: a5ef3f89337c7db3403a3a07a6edbc0652967f65