i3lock-color
i3lock-color copied to clipboard
Raymo111
When new release? Modifier keys updated on i3lock
i3lock is at release 2.14.1. When is i3lock-color planning to make the new release?
The main reason for asking is bc I wanted the keyboard modifiers to show when typing (see the issue in https://github.com/i3/i3lock/issues/225) Tho a quick look of the commits shows that they added a -k flag for this, going into conflict with the option -k of this fork (see https://github.com/Raymo111/i3lock-color/commit/3b6511d4a59b05c4f4fb16ec8c30631d4b4d15ea)
| i3lock | i3lock-color | |
|---|---|---|
| -k flag | forces keeb modifiers | clock |
There's been a lot of breaking changes from upstream, including moving from M4 to meson. I couldn't even cherry-pick that commit over because of the conflicting option. I'm not planning on doing a merge from upstream in a while, but:
- I did release 2.13.c.5 a couple days ago, and
- If someone else feels like merging from upstream I'll be happy to review the PR.
@Raymo111 Thanks for the info. This afternoon I'm going to look into the commits and try to bump up the version.
How should the -k behave tho? It's going to be a braking change with previous configs if the new behavior is chosen. Should I maintain the -k for the clock or should I follow the original repo (with the keyboard option)?
Let's not break existing workflows, the new option can just have a long opt and not a short one.