Ramon Wijnands

Results 68 comments of Ramon Wijnands

I think you could interpret a `unsubscribe()` call in two ways: 1. Remove all previously registered listeners 2. Stop listening to the topic, but keep the listeners in tact (essentially...

Are you storing the handle so you can later unsubscribe? ```js var handle = listener.subscribe(handleMsg); listener.unsubscribe(handle); ```

How do you know "roslib did not pick this up". What error did you get? Did you get the following message? `throw 'Cannot process BSON encoded message without BSON header.';`

You could take a look at the `examples` folder in this repo: https://github.com/rctoris/mjpegcanvasjs

I would advise to keep the changes focussed on one topic as this makes it easier to review. Please create additional PRs for aditional topics (such as changing and fixing...

Hi, what is the status of the ES6 migration? I'm really interested because ES6 imports mean for me a reduced bundle size by tree shaking. I see that there are...

Indeed, it should be relatively easy to implement. In the action client it's implemented here: https://github.com/RobotWebTools/roslibjs/blob/f0d6d6a6dcaadb8abacb47a5a82b126af79f84e8/src/actionlib/ActionClient.js#L135

I think that the construction of `final_points` is wrong. Can you try this? ```js var final_points = new ROSLIB.Message({ parray: tempArray }); this.Path.publish(this.final_points) ```

After some quick googling I found 2 ROS2 projects that might interest you: - https://github.com/younata/rclSwift - https://github.com/atyshka/ros2_swift

You are right, I broke the tests. I've now fixed them. I've to check webpack next to make sure I'm not breaking anybody's workflow.