grunt-sitemap icon indicating copy to clipboard operation
grunt-sitemap copied to clipboard

`pattern` should take into account `siteRoot` option

Open XhmikosR opened this issue 10 years ago • 5 comments

sitemap: {
    dist: {
        pattern: ['./dist/**/*.html', '!./dist/**/google*.html'],
        siteRoot: './dist'
    }
},

should be

sitemap: {
    dist: {
        pattern: ['**/*.html', '!**/google*.html'],
        siteRoot: './dist'
    }
},

XhmikosR avatar Jan 08 '15 16:01 XhmikosR

I think I get what you're saying, but could you explain just a bit further? Maybe an example of what happens now, and what should happen?

counterbeing avatar Jan 09 '15 00:01 counterbeing

I added more details in my OP.

XhmikosR avatar Jan 09 '15 08:01 XhmikosR

I think that makes sense, but it seems like the kind of change that might break things for current users. Maybe we should put that in a 1.3.0 release?

counterbeing avatar Jan 09 '15 08:01 counterbeing

First, we need to fix it :p IMO that's a bug so if we consider it as such it should be in 1.2.2. Otherwise, 1.3.0.

XhmikosR avatar Jan 09 '15 08:01 XhmikosR

Reopening since I had to revert the patch because it caused issues.

XhmikosR avatar Dec 04 '18 14:12 XhmikosR